Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional reason when using the stopgame command. #4323

Merged
merged 1 commit into from Sep 13, 2019

Conversation

@Pentarctagon
Copy link
Member

commented Sep 7, 2019

So now: /query stopgame <nick> [<reason>]. The reason is displayed to the players of the game on the savegame prompt dialog.

@Wedge009 Wedge009 added the MP label Sep 7, 2019

src/playturn.cpp Outdated Show resolved Hide resolved

@Pentarctagon Pentarctagon force-pushed the Pentarctagon:stopgame-command-reason branch from 27f9b09 to b49bdbd Sep 8, 2019

src/server/server.cpp Outdated Show resolved Hide resolved
Add optional reason when using the stopgame command.
So now: `/query stopgame <nick> [<reason>]`. The reason is displayed to the players of the game on the savegame prompt dialog.

@Pentarctagon Pentarctagon force-pushed the Pentarctagon:stopgame-command-reason branch from b49bdbd to c30d74d Sep 11, 2019

@soliton-

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

Can you try what happens if the reason contains a double quote?

@Pentarctagon

This comment has been minimized.

Copy link
Member Author

commented Sep 12, 2019

It causes no issue: https://i.imgur.com/Pd1Jh3x.png

@soliton-

This comment has been minimized.

Copy link
Member

commented Sep 13, 2019

Right, the WML is of course generated on the client and the server just copies it. Looks all good to me then.

@soliton- soliton- merged commit 14c0272 into wesnoth:master Sep 13, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@soliton-

This comment has been minimized.

Copy link
Member

commented Sep 13, 2019

Feel free to backport to 1.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.