Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttT S23: Give a more explicit hint on EASY #4329

Merged
merged 3 commits into from Sep 14, 2019

Conversation

@jostephd
Copy link
Member

commented Sep 9, 2019

There's a dialog hint just above the diff:

[message]
speaker=Bayar
message= _ "No, whelp. You may be weakened, but the horse clans are eternal. I will promise you this, however. If you can defeat me personally, I myself will join your siege of Weldyn."
[/message]

But on EASY, make the hint explicit.

Come to think of it, the dialog hint is actually ambiguous: "defeat me personally" can be understood as though Konrad has to attack Lord Bayar, can't it? So how about removing the word "personally" from that line?

@jostephd jostephd added this to the 1.16.0 milestone Sep 9, 2019

@jostephd jostephd self-assigned this Sep 9, 2019

@jostephd jostephd requested a review from stevecotton Sep 9, 2019

@@ -308,6 +308,9 @@
speaker=Sir Alric
message= _ "Aye."
[/message]
#ifdef EASY
{NARRATOR_MESSAGE (_ "If you reduce Lord Bayar, Sir Ruga, Sir Daryn, or Sir Alric to 0HP, you'll receive a reward!")}

This comment has been minimized.

Copy link
@stevecotton

stevecotton Sep 9, 2019

Contributor

Should use a typographic apostrophe in you’ll. Other than that, I like the change.

This comment has been minimized.

Copy link
@Wedge009

Wedge009 Sep 9, 2019

Member

Looks good to me as well.

This comment has been minimized.

Copy link
@jostephd

jostephd Sep 9, 2019

Author Member

Thanks, fixed and force pushed.

While here I wonder if there are other places in the novice/rookie level campaigns where we could add such hints?

HttT S23: Give a more explicit hint on EASY
Thanks to forum user "Poison".

@jostephd jostephd force-pushed the jostephd:httt-S23-hint branch from 1d90f34 to 2c43569 Sep 9, 2019

@GregoryLundberg

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

Any reason your adding a new macro only used once?

@jostephd

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

Any reason your adding a new macro only used once?

There are tens of places in HttT where this macro could be used. I didn't think it was a good idea to go through and update all of them, though. We can make those other places use the macro the next time we change them.

@@ -471,6 +471,9 @@
speaker=unit
message= _ "We are desperately trying to rid these tunnels of orcs and trolls! Please help us in our quest."
[/message]
#ifdef EASY
{NARRATOR_MESSAGE (_ "The dwarves are your allies in this scenario. If you help them survive the battle, they may provide you with useful information.")}

This comment has been minimized.

Copy link
@stevecotton

stevecotton Sep 11, 2019

Contributor

"if you help their leader survive the battle" would be clearer about exactly what the player has to do.

The reward is troops rather than information, although he gives some information too.

This comment has been minimized.

Copy link
@jostephd

jostephd Sep 11, 2019

Author Member

How about If you help their leader survive the battle, he may provide you with useful information? This emphasizes the leader, but Konrad doesn't know in advance what the reward will be.

@jostephd jostephd modified the milestones: 1.16.0, 1.14.9 Sep 12, 2019

@jostephd jostephd merged commit 43fb5fa into wesnoth:master Sep 14, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jostephd added a commit that referenced this pull request Sep 14, 2019
jostephd added a commit that referenced this pull request Sep 14, 2019
Add #4329 #4334 #4337 to changelog.
(cherry picked from commit de8a913)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.