Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deprecated terrain to wmllint #4340

Open
wants to merge 1 commit into
base: master
from

Conversation

@sevu
Copy link
Member

commented Sep 13, 2019

This code is not offered in the map editor anymore. Are there more cases?
And where else could we communicate that this is deprecated?

@Pentarctagon

This comment has been minimized.

Copy link
Member

commented Sep 13, 2019

The changelog would be a good place, so it'll be mentioned in the 1.15.2 release notes.

@sevu

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2019

It's an old change unrelated to 1.15, this just adds a rule for it, will maybe also backport his to 1.14. Seems it missed a changelog entry somewhere in 1.13, but no sense in adding one now. Well, at least it's been removed from https://wiki.wesnoth.org/TerrainCodeTableWML, which is I think the only documentation of supported Terrain Codes.

@Pentarctagon

This comment has been minimized.

Copy link
Member

commented Sep 14, 2019

Do deprecated terrains have any ingame or logged warning?

@Wedge009 Wedge009 added the WML Tools label Sep 14, 2019
@stevecotton

This comment has been minimized.

Copy link
Contributor

commented Sep 14, 2019

^Uf has been replaced in #4299 (for 1.15 only)

@sevu

This comment has been minimized.

Copy link
Member Author

commented Sep 16, 2019

Do deprecated terrains have any ingame or logged warning?

Seems that not. What is done is that they are not placable via the editor anymore, but are still working i.e. so that one can replace them using the editor.

Hmmmm, wmllint does nothing with "Xol,", only if it is "Xol". Which matches also Xol terrain which has already an overlay (are there any though)

It's not anymore offered in the map editor
[ci skip]
@sevu sevu force-pushed the sevu:terrain-wmllint branch from 3b01c1a to 40bfc36 Sep 16, 2019
@stevecotton

This comment has been minimized.

Copy link
Contributor

commented Sep 22, 2019

Hmmmm, wmllint does nothing with "Xol,", only if it is "Xol". Which matches also Xol terrain which has already an overlay (are there any though)

You could enable the commented-out maptransform_error code, and throw if wmllint meets "Xol^".

@Elvish-Hunter

This comment has been minimized.

Copy link
Contributor

commented Sep 23, 2019

You could enable the commented-out maptransform_error code, and throw if wmllint meets "Xol^".

Instead of throwing, wouldn't it be better to have wmllint skip that transformation and print to stderr something like "wmllint: terrain code Xol^ requires manual fixing"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5 participants
You can’t perform that action at this time.