Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRoW S04a S04b: From Midlands, make Swamp the next scenario #4377

Open
wants to merge 1 commit into
base: master
from

Conversation

@stevecotton
Copy link
Contributor

commented Sep 23, 2019

Originally two commits, the first one is now merged. I expect debate and possibly rejection of the remaining commit in this PR.

TRoW S04a S04b: Move Sir Ladoc / Sir Ruddry to the victory event

This means that they join even when debugging with the :next_level command.

The enemies_defeated event could be replaced by victory_when_enemies_defeated
and the appropriate carryover amounts, but that should probably be done as a
single commit updating the entire campaign.

@nemaara - this is similar to #3801, please would you review it?

TRoW S04a S04b: From Midlands, make Swamp the next scenario

The Midlands is the more challenging option, but means missing out on an auto-recalled loyal white mage. The journey map also shows that The Oldwood is east of The Swamp of Esten, and it makes little sense that they reach Oldwood without passing through the swamp. Solve both problems by making The Midlands an optional detour which still ends up going through the swamp.

If the player took the extra XP by going through The Midlands, the turn limit on The Swamp is much tighter. Sir Ruddry will appear during the start event, tell Haldric about the road ahead, and then die - Sir Ladoc gets an exposition that only one of the two knights can survive.

I've left the scenario number unchanged, although this means that 04b will occur (if the player chooses to go there) before 04a.

@stevecotton stevecotton requested a review from ln-zookeeper Sep 23, 2019
@nemaara

This comment has been minimized.

Copy link
Contributor

commented Sep 23, 2019

Looks fine to me. I don't have an opinion on your second commit, so maybe wait for zookeeper to make his comments?

@stevecotton stevecotton force-pushed the stevecotton:trow_mid_swamp branch from aa03212 to 393505d Sep 27, 2019
@stevecotton

This comment has been minimized.

Copy link
Contributor Author

commented Oct 6, 2019

@ln-zookeeper please would you comment on this?

The merge conflict is just the change from map_data= to map_file=.

@clockback

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2019

It does seem unreasonable for the player to beat a harder scenario and miss out on a loyal white mage in return. In the interest of balancing the game, such that one is not handicapped later on for completing a difficult optional scenario.
I also agree that travelling through the swamp seems somewhat unavoidable, given the apparent threat of the orcs. Provided that the commit has been tested, this seems like a good alteration to make.

The Midlands is the more challenging option, but means missing out on
an auto-recalled loyal white mage. The journey map also shows that The
Oldwood is east of The Swamp of Esten, and it makes little sense that
they reach Oldwood without passing through the swamp. Solve both
problems by making The Midlands an optional detour which still ends up
going through the swamp.

If the player took the extra XP by going through The Midlands, the
turn limit on The Swamp is much tighter. Sir Ruddry will appear during
the start event, tell Haldric about the road ahead, and then die - Sir
Ladoc gets an exposition that only one of the two knights can survive.

I've left the scenario number unchanged, although this means that 04b
will occur (if the player chooses to go there) before 04a.
@stevecotton stevecotton force-pushed the stevecotton:trow_mid_swamp branch from 393505d to bab2402 Oct 12, 2019
@stevecotton stevecotton changed the title WIP: TRoW S04a S04b: From Midlands, make Swamp the next scenario TRoW S04a S04b: From Midlands, make Swamp the next scenario Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.