Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display: Don't move the center of the viewport when zooming in when the map is narrower/shorter than the viewport #4442

Merged
merged 1 commit into from Oct 15, 2019

Conversation

@jostephd
Copy link
Member

commented Oct 9, 2019

In the test scenario, toggling between 50%/100% zoom on 1920x1080 will now correctly switch between "Show the entire map" (50%) and "Show just the center of the map" (100%).

Fixes #1951

…he map is narrower/shorter than the viewport

In the test scenario, toggling between 50%/100% zoom on 1920x1080 will
now correctly switch between "Show the entire map" (50%) and "Show just
the center of the map" (100%).

Fixes #1951
@Wedge009

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

Maybe I'm looking at the wrong thing but any difference between this and master is subtle. At least I don't see anything horribly amiss.

@jostephd

This comment has been minimized.

Copy link
Member Author

commented Oct 10, 2019

In master, when I zoom out to 50% I can see the entire map, and when I zoom back in I get to this point:

2019-10-10-023742_171x118_scrot

In this PR, after zooming back in, the point at the center of the viewport doesn't move:

2019-10-10-023822_170x114_scrot

@jostephd jostephd merged commit f9fc82d into wesnoth:master Oct 15, 2019
2 of 3 checks passed
2 of 3 checks passed
label label
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jostephd added a commit that referenced this pull request Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.