Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trackplacer as a read-only animation preview application #4574

Merged
merged 1 commit into from Nov 18, 2019

Conversation

@stevecotton
Copy link
Contributor

stevecotton commented Nov 16, 2019

Combined with tmx_trackplacer, this now has feature-parity with the old version,
without the reliance on python2 or pygtk (fixes #4365).

Shows the journey without needing to start Wesnoth and refresh the cache.
Currently this does not have editing functions, instead it's a support program
which assumes you're either editing the .cfg file with a text editor or using
Tiled with tmx_trackplacer.

At least on Linux you can have both Tiled and this open on the same file. Save
the file in Tiled, alt+tab to this, and press enter to reload the file.

@Elvish-Hunter

This comment has been minimized.

Copy link
Contributor

Elvish-Hunter commented Nov 16, 2019

I'd suggest you to rename this script as trackplacer_viewer.pyw or something similar, for three reasons:

  • it makes its purpose clear from the beginning;
  • it leaves the trackplacer name available for a possible future stand-alone version;
  • the .pyw extension is needed on Windows to avoid opening a Command Prompt window too.
Trackviewer shows a journey without needing to start Wesnoth and refresh the
cache. Combined with tmx_trackplacer, the python3 versions now have
feature-parity with the old trackplacer, without the reliance on python2 or
pygtk (fixes #4365).

At least on Linux you can have both Tiled and this open on the same file. Save
the file in Tiled, alt+tab to this, and press enter to reload the file.
@stevecotton stevecotton force-pushed the stevecotton:trackplacer3 branch from a96eeb1 to 2c9caab Nov 18, 2019
@stevecotton stevecotton merged commit 2c9caab into wesnoth:master Nov 18, 2019
0 of 2 checks passed
0 of 2 checks passed
Travis CI - Pull Request Build Errored
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
@stevecotton stevecotton deleted the stevecotton:trackplacer3 branch Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.