Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4135 - add the "Advances to" tooltip to the recruit and recall dialogs #4676

Merged
merged 4 commits into from Jan 24, 2020

Conversation

@rjframe
Copy link
Contributor

rjframe commented Dec 30, 2019

Moves creation of the advancement tooltip text when you mouseover the "Lvl [number]" in the sidebar to a helper function and convert's the recruit/recall dialog's level_label_ to a gui2::implementation::styled_widget so we can add the tooltip.

I merged the two "User Interface" sections for master in the changelog.

There's a lot of duplication in unit_preview_pane::set_displayed_type (recruit list) and unit_preview_pane::set_displayed_unit (recall list); they've diverged a bit over time, but I haven't looked closely enough to see how much of that is intentional versus forgetting to update both.

rjframe added 4 commits Dec 30, 2019
There were two "User Interface" sections in  the changelog for
1.15.2+dev so I merged them.
Fixes #4135

This commit:
- Moves creation of the tooltip text to a helper function.
- Converts the dialog's label to a styled_widget to allow setting a
  tooltip.
@Wedge009 Wedge009 added the UI label Dec 31, 2019
@Vultraz Vultraz self-assigned this Jan 19, 2020
Vultraz added a commit that referenced this pull request Jan 24, 2020
@Vultraz Vultraz merged commit 03beac2 into wesnoth:master Jan 24, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.