Move the Naga Hunter unit to core

[CelticMinstrel]

This allows addons to safely use it without having to copy the files into their own addon directory.

[stevecotton]

Please add a log to the changelog_entries directory.

[knyghtmare]

PR seems good to go, but I think there was animations for the Naga Assassin unit. Might add in a follow-up PR

[Pentarctagon]

Needs doofus-01's review for the new Naga Assassin sprite.

[Jonathan-Kelly]

This old unit heavily overlaps with the new naga dirkfang line, specifically the ophidian branch. Why not just give the ophidian or sicarius poison on its ranged attack and then discontinue this unit altogether? Replace all instances of it in UtBS with the new dirkfang line?

[doofus-01]

This unit is fine as a campaign-specific unit, but I'm opposed to moving it to core. As Jonathan-Kelley says, there is overlap with the dirkfang line, and I remember seeing a more creative version of Naga Assassin in UMC that this might conflict with. This has a Lordbob (I think?) portrait, but otherwise there's nothing special here.

Like I'd mentioned in #7335 - if there is some middle ground to directly mainlining, that makes the assets available to all without committing this to core, I would not object.

[CelticMinstrel]

Why was this closed?

[sevu]

I think it does make sense to close it if the dirkfang takes the role of the hunter.

[CelticMinstrel]

Maybe, but this one does have a pretty good portrait.

[doofus-01]

If there are plans to work on the sprite, it makes sense to leave it open. Otherwise, closing it and linking an Issue makes sense, maybe someone else will pick it up. It's not like the portrait is getting tossed if this is closed.

[doofus-01]

No sign that there is any work going on here, so I'm opposed to merging this into BfW 1.17/1.18. Maybe it can be a goal for BfW 1.19/1.20.

[Pentarctagon]

Is this PR still being pursued?

[cooljeanius]

Is this PR still being pursued?

Kinda 50/50 on this; in the add-ons where I might need a Naga Hunter, I've already copied it over, and thus I wouldn't really need this PR myself, but for new ones it might be useful. @CelticMinstrel WDYT?

[CelticMinstrel]

I would still like this merged, yes.

[doofus-01]

I'd say this is in the same boat as #7325; it could be a project for 1.191.20. Or maybe it could go into an "official add-on" if that's still being considered.

[spixi]

Maybe the portrait could be repurposed for a new line or the current Naga Hunter line could get a rework. The Dirkfang line is a classic mixed fighter line protecting the water frontline and the Hunter line could be more an assassin-like utility unit line with the high movement and poison special.

[cooljeanius]

It seems that there are merge conflicts now?

[CelticMinstrel]

Did someone update the naga hunter animations or something? Unless it's a case of move vs delete, the conflicts are probably trivial to resolve (just accept the upstream version).

[cooljeanius]

Did someone update the naga hunter animations or something? Unless it's a case of move vs delete, the conflicts are probably trivial to resolve (just accept the upstream version).

I'm wondering if this is a side effect of doofus's updates to move all the copyright info to image metadata...

[CelticMinstrel]

Ah yes, that's likely it.