Add the Elvish Hunter line to mainline #7329
Conversation
github-actions
bot
added
Graphics
|
I converted it to draft because I noticed the unit files still need updating. |
github-actions
bot
added
the
UI
CelticMinstrel
force-pushed
the
elf_hunter
branch
from
814c4f2 to
94642b3
Compare
CelticMinstrel
removed
the
UI
|
I've got no issue with the concept and do understand the motivation, but these are old frankensprites. I'd need to see a little more effort before I can approve. Whatever way this gets resolved will be tied to all the other things currently being proposed. |
|
I hope @Elvish-Hunter doesn't mind my requesting a review from him just based on his name... 😃 |
There was a problem hiding this comment.
I've got no issue with the concept and do understand the motivation, but these are old frankensprites. I'd need to see a little more effort before I can approve.
Marking this as "changes requested" because otherwise it shows up in the PR list as "approved". When @doofus-01's comment is addressed, please feel free to remove me from the reviewers list.
| hills=40 | ||
| sand=60 | ||
| [/defense] | ||
| description=_"Elvish hunters are specialized in trapping unwary opponents from a safe distance to ease the task of the swordsmen." |
There was a problem hiding this comment.
For a mainline unit, I'd expect a longer text. Maybe something about not all groups having shamans, or about the trappers having more movement than the shamans, maybe that the hunters aren't too bad in melee.
Probably should be something more gender-neutral than "swordsmen".
There was a problem hiding this comment.
I seem to be hitting a block on how to make it longer. Your suggestions make sense, but turning that into reasonable prose is harder than it sounds.
I'm not opposed to making it gender-neutral, but it's probably mainly referring to the fighter line which is mechanically all-male.
There was a problem hiding this comment.
If this is still a problem, I can write one. You'd just have to tell me what it needs to say. (If the unit is even going to be added)
|
Honestly, this old unit seems quite redundant with the elvish fighter and elvish shaman. So the effort it would take to update its mediocre looking sprite would probably be better applied to more useful unit designs. |
stevecotton
dismissed
their stale review
Dismissed temporary review that was added because doofus-01 requested changes but didn't at that time use Github's "request changes" status.
|
To make the unit more interesting, maybe "their skill at spotting routes to follow prey lets them give hints to adjacent units about the fastest path", and give them tailwind+1. |
Believe me you dont want to make them even more op then they already are. This unit would end up at like 28g. |
|
this PR should be updated so that it passes the new copyright checker CI task |
@CelticMinstrel could you please look into this? |
|
I don't know where the Elvish Hunter unit originated. As I recall, I got these sprites from either IftU or AtS, but I do not know where Iris obtained them before that. There used to be a hunter in UtBS, but that was a "brown" version of this one. I'm not sure exactly what relationship the UtBS sprites have with these ones; either one could've been based on the other. Given that it's pretty close to the archer, I'd guess it's probably GPL, but I don't know for sure. |
|
The images would need some changes/additions anyways, so no need to worry about the CSV for now. |
CelticMinstrel
force-pushed
the
elf_hunter
branch
from
f464b49 to
037e416
Compare
I think she drew them herself: |
|
One thing I agree with doofus here is that the level 2 and level 3 need the minimal animations done. They are just the base image for now. However, given that the current Sylph is also just a base image, I am not sure if this minimal requirement is still in effect. |
|
@cooljeanius Not entirely true. Quoting myself from the first post you linked:
Thus, technically they are just edits of Jetrel's (IIRC) version of both units. |
Fix textdomains Remove special notes
CelticMinstrel
force-pushed
the
elf_hunter
branch
from
037e416 to
f0fb25f
Compare
These are sort of a relic from the pre-Quenoth desert elves, only converted back to a wood elf. I think it's a nice flavour unit to have for some campaigns.