Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build on GNU/Hurd due to PATH_MAX #138

Closed
sthibaul opened this issue Dec 19, 2016 · 4 comments
Closed

Fails to build on GNU/Hurd due to PATH_MAX #138

sthibaul opened this issue Dec 19, 2016 · 4 comments

Comments

@sthibaul
Copy link
Contributor

Hello,

As reported on http://bugs.debian.org/838133 , flex currently fails to build on GNU/Hurd because it unconditionnally uses PATH_MAX. The attached patchpatch.txt makes it just dynamically allocate the proper buffer size.

Actually flex even bogusly used PATH_MAX, since it checked for "path" being not too long, but didn't take into account the additional length of "m4", so the proposed patch is actually a bugfix on !hurd too: if PATH contains a path with more than PATH_MAX characters, the additional "m4" two bytes were overflowing the m4_path array.

Samuel

@westes
Copy link
Owner

westes commented Dec 19, 2016

This patch does not apply against master. Could you check out the current tree and resubmit?know if you need a

@sthibaul
Copy link
Contributor Author

Here is a rebased patch
patch.txt

@westes
Copy link
Owner

westes commented Dec 20, 2016

What email address should I use for you on this patch?

@sthibaul
Copy link
Contributor Author

samuel.thibault@ens-lyon.org please

@westes westes closed this as completed in 7975c43 Dec 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants