New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add location to buildings with negative layer from -1 to -5 #912

Closed
matkoniecz opened this Issue Feb 25, 2018 · 5 comments

Comments

Projects
None yet
5 participants
@matkoniecz
Copy link
Contributor

matkoniecz commented Feb 25, 2018

General

Affected tag(s) to be modified/added: location
Question asked: Is this building is existing and located underground?

Checklist

Checklist for quest suggestions (see guidelines):

  • 馃毀 To be added tag is established and has a useful purpose (it is used in StreetComplete itself, allows to clearly mark something as underground - some mappers use solely negative layer/level and expect that it is enough to describe something as located underground)
  • 馃 Any answer the user can give must have an equivalent tagging (Quest should not reappear to other users when solved by one) location=underground/surface/overground/overhead should cover all cases, except complete mistaggings
  • 馃惪锔 Easily answerable by everyone from the outside but a survey is necessary: distinguishing location=surface/overground/overhead requires survey, checking whatever structure exists requires survey
  • 馃挙 Not an overwhelming percentage of elements have the same answer (No spam)
  • 馃晸 Applies to a reasonable number of elements (Worth the effort)

Ideas for implementation

Element selection: http://overpass-turbo.eu/s/wv2

Metadata needed: no

Proposed GUI:
Related GUI:
Inspired by #907

@goldfndr

This comment has been minimized.

Copy link
Contributor

goldfndr commented Feb 25, 2018

You could simplify the query to way["building"]["layer"~"-.*"]["location"!~".*"]({{bbox}}); in case someone uses a number beyond -5. Although it's improper to exceed -5, such instances can usually be solved by an armchair mapper. openstreetmap-carto accepts integers -99 to 99.

@westnordost

This comment has been minimized.

Copy link
Owner

westnordost commented Feb 25, 2018

Well, in StreetComplete, one can use a simplified tag query syntax anyway:
ways, relations with building and layer ~ -.* and !location

@rugk

This comment has been minimized.

Copy link
Contributor

rugk commented Mar 6, 2018

Hmm, don't understand this quest. So this is basically correcting a tagging mistake (only tagging layer=).
And when the building is underground, should not it usually be tagged with level?

Here something is tagged with building:levels:underground=1. Is not that enough, so is this location tag really needed?

@ENT8R

This comment has been minimized.

Copy link
Contributor

ENT8R commented Mar 6, 2018

I think it is needed, because without that location=underground tag, there will be underground train stations displayed as normal overground buildings on the map of SC...

@matkoniecz

This comment has been minimized.

Copy link
Contributor

matkoniecz commented Mar 6, 2018

So this is basically correcting a tagging mistake

Yes.

Here something is tagged with building:levels:underground=1. Is not that enough, so is this location tag really needed?

At least for me at this moment it is not entirely clear. If that object is entirely underground, I would add also location=underground.

building:levels:underground=1

building:levels:underground=1 may be given to any object that has 1 level underground, not only ones entirely underground.

I think it is needed, because without that location=underground tag, there will be underground train stations displayed as normal overground buildings on the map of SC...

I would add it because it is useful tag explaining situation, not just because one particular data consumer relies on it.

matkoniecz added a commit to matkoniecz/Zazolc that referenced this issue Nov 19, 2018

Is building undreground quest
fixes westnordost#912

this a bit unusual quest help to fix one of common tagging mistakes

main use of adding missing location=underground in case of SC is to skip this weird buildings
in other quests

matkoniecz added a commit to matkoniecz/Zazolc that referenced this issue Nov 19, 2018

Is building underground quest
fixes westnordost#912

this a bit unusual quest help to fix one of common tagging mistakes

main use of adding missing location=underground in case of SC is to skip this weird buildings
in other quests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment