New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding traffic_signals:sound tag [ready for review] #1268

Merged
merged 3 commits into from Nov 20, 2018

Conversation

Projects
None yet
3 participants
@matkoniecz
Copy link
Contributor

matkoniecz commented Nov 19, 2018

fixes part of #574

I want to test is it flood of "no" answers. It is also likely that it needs enabling/disabling for specific countries.

@matkoniecz

This comment has been minimized.

Copy link
Contributor

matkoniecz commented Nov 19, 2018

Is anybody aware whatever there are countries with traffic lights where sounds for people with poor eyesight are really rare? I plan to run checks based on raw OSM data but this kind of data is biased in many ways.

@westnordost

This comment has been minimized.

Copy link
Owner

westnordost commented Nov 19, 2018

Hmm, I would rather like to have a whitelist rather than a blacklist, I think. On the other hand, it is really difficult to research this information, i.e. Google Streetview etc. is not helpful here obviously, so it may be a better idea to start off with enabled-almost-everywhere and then exclude countries bit by bit where it turns out that they do not have this at all.

@matkoniecz matkoniecz changed the title adding traffic_signals:sound tag [WIP] adding traffic_signals:sound tag [WIP, retest] Nov 19, 2018

@matkoniecz

This comment has been minimized.

Copy link
Contributor

matkoniecz commented Nov 19, 2018

As expected, checking raw OSM data was not too helpful. There are some obvious cases for inclusion, but most countries are completely missing this tag.

At this point I would recommend rolling it out everywhere and checking statistics in month or two.

But restrictive whitelist and waiting for reports from people who want this quest in their country would be also OK.

@westnordost

This comment has been minimized.

Copy link
Owner

westnordost commented Nov 19, 2018

The quest is pretty low prio, so that's okay

@matkoniecz matkoniecz force-pushed the matkoniecz:sound branch from 1855497 to 447d7a9 Nov 20, 2018

@matkoniecz matkoniecz changed the title adding traffic_signals:sound tag [WIP, retest] adding traffic_signals:sound tag [ready for review] Nov 20, 2018

@matkoniecz

This comment has been minimized.

Copy link
Contributor

matkoniecz commented Nov 20, 2018

@westnordost BTW, you may want to look at #574

It has three suggestions, this PR implements one. I think that from two remaining ones - first is not suitable for quest and second is not worth implementing.

If you think that arrow quest is worth implementing - I may do that, and keep it as low priority Germany-only quest.

Show resolved Hide resolved app/src/main/res/values/strings.xml Outdated
add (hopefully missing) "the"
Co-Authored-By: matkoniecz <matkoniecz@gmail.com>

@westnordost westnordost merged commit 70b6ed3 into westnordost:master Nov 20, 2018

@matkoniecz matkoniecz deleted the matkoniecz:sound branch Nov 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment