Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we're checking if the speed value is unusual #1632

Merged
merged 1 commit into from Nov 10, 2019

Conversation

peternewman
Copy link
Collaborator

Not the converted value in kmh, otherwise every mph value will be odd.

As I stuck in a comment in here:
https://github.com/westnordost/StreetComplete/pull/1622/files#r344422067

This throws an "implausible" warning for 20 mph in the UK, and would do the same for 30. The % 5 bit needs to be done on the raw speed value rather than the converted kmh value.

I'm not quite sure how I didn't hit this before, or is this only triggered in some cases (this was a zone not a sign).

This code is entirely untested, but seemed trivial enough it was worth just opening a PR rather than an issue.

Not the converted value in kmh, otherwise every mph value will be odd
@westnordost westnordost merged commit 095eeb5 into streetcomplete:master Nov 10, 2019
@westnordost
Copy link
Member

Thanks!

matkoniecz added a commit to matkoniecz/Zazolc that referenced this pull request Nov 10, 2019
matkoniecz added a commit to matkoniecz/Zazolc that referenced this pull request Nov 10, 2019
westnordost pushed a commit that referenced this pull request Nov 10, 2019
@peternewman peternewman deleted the patch-3 branch May 6, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants