New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an extra application ID suffix for the debug version #630

Merged
merged 1 commit into from Oct 8, 2017

Conversation

Projects
None yet
3 participants
@ENT8R
Contributor

ENT8R commented Oct 5, 2017

This PR adds an application ID suffix for the debug version in the build.gradle file. It is then possible to have a stable version installed and besides also a version for debugging purposes.
The name of the application in the debug version is "StreetComplete Dev", so that you can distinguish between the two applications.
This PR fixes #591.
And this is how it looks like:

@westnordost

This comment has been minimized.

Owner

westnordost commented Oct 7, 2017

Whoops, I thought I commented on that already. Basically: Cool thing, didn't know it was possible!

Two points though:

  1. Did you test it? I.e. are the two apps then really completely apart? Different DB etc.
  2. Why did you add the file app/src/debug/res/xml/preferences.xml ?
@ENT8R

This comment has been minimized.

Contributor

ENT8R commented Oct 7, 2017

are the two apps then really completely apart?

Good point... I haven't thought about this... But I can only test it next weekend, because I'm currently offline for a week again.🏝

Why did you add the file app/src/debug/res/xml/preferences.xml?

Because of line 3. The value has to be the exact ID of the application.

@rugk

This comment has been minimized.

Contributor

rugk commented Oct 7, 2017

are the two apps then really completely apart?

AFAIK (theoretically) yes. I did something similar when creating #591 (but deleted the settings stuff, getting into my way) and had an older version and the dev version installed. Android's whole app concept is based on sandboxing, so two app IDs = two apps = fully sandboxed = fully different.

Because of line 3. The value has to be the exact ID of the application.

Ah, so that is the actual workaround for the issue #591.

@westnordost westnordost merged commit 5518c8d into westnordost:master Oct 8, 2017

@westnordost

This comment has been minimized.

Owner

westnordost commented Oct 8, 2017

I was able to remove the preferences.xml by using res-auto instead.

@ENT8R ENT8R deleted the ENT8R:change-app-id branch Oct 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment