New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new quest to determine the tracktype #959

Merged
merged 9 commits into from Oct 27, 2018

Conversation

Projects
None yet
5 participants
@ENT8R
Copy link
Contributor

ENT8R commented Mar 8, 2018

This PR adds a new quest for determining the surface quality of a track. It fixes #487.

ENT8R added some commits Dec 19, 2017

@westnordost

This comment has been minimized.

Copy link
Owner

westnordost commented Mar 8, 2018

Actually, I made an icon specifically for that, it's the tractor.

@westnordost
Copy link
Owner

westnordost left a comment

A few points:

  1. Whoa, how did you scale those, with MSPaint? Looking especially at tracktype 2,3 and 4 it really does not look so pleasant
  2. On the pictures, the very much most important part of this quest:
  • track1 shows too much sky and too little of the track. I cannot really identify the surface
  • track2 looks kind of less smooth than 3, where should be the tangible difference between these?
  • track4 is bad, it should have the same appearance (minus the track) than the other pictures, not this red-brownish heathlands
@rugk

This comment has been minimized.

Copy link
Contributor

rugk commented Mar 9, 2018

Actually, I made an icon specifically for that, it's the tractor.

Uhh? I actually correlate this icon used here much more with "track/way surface" than a tractor. A tractor may be about agriculture, so a quest about plants on a field or whatever. (I know, not a quest we want.)

And if you considered to use the tractor for that, what did you want to do with this icon?

@ENT8R

This comment has been minimized.

Copy link
Contributor

ENT8R commented Mar 9, 2018

Whoa, how did you scale those, with MSPaint?

This was my tool/website which did this 😄 I fear this needs some adjustment...

Actually, I made an icon specifically for that, it's the tractor.

I also thought that this icon would fit a little bit better...

Regarding the images: I will look for some better ones that will fit your proposals.

@westnordost

This comment has been minimized.

Copy link
Owner

westnordost commented Mar 9, 2018

And if you considered to use the tractor for that, what did you want to do with this icon?

#279

@ENT8R

This comment has been minimized.

Copy link
Contributor

ENT8R commented Mar 9, 2018

Mmh... Alright. I find this still a little bit confusing.

@rugk

This comment has been minimized.

Copy link
Contributor

rugk commented Mar 9, 2018

Mhh ok. Considering the asked question, maybe the icon should try to represent quality somehow? Some +/- signs, 👍/👎 or so (in a simplified way) or so on a street, maybe?

@goldfndr

This comment has been minimized.

Copy link
Contributor

goldfndr commented Mar 10, 2018

Rather than quality, I suggest firmness.

@ENT8R

This comment has been minimized.

Copy link
Contributor

ENT8R commented Mar 28, 2018

track2 looks kind of less smooth than 3, where should be the tangible difference between these?

Maybe this is just because of the bad quality of the images, but I think grade2 is something like gravel and grade3 is sand or something softer...

@ENT8R

This comment has been minimized.

Copy link
Contributor

ENT8R commented Mar 28, 2018

track1 shows too much sky and too little of the track. I cannot really identify the surface

maybe this one is better?
Or is there too much forest?
https://wiki.openstreetmap.org/wiki/File:Cesta_od_Le%C5%A1tiny_do_Lipnice_nad_S%C3%A1zavou_(2).jpg

@rugk

This comment has been minimized.

Copy link
Contributor

rugk commented Mar 28, 2018

Maybe it would be better if it had been photographed from an even lower position (i.e. frog perspective, but not looking up, but just straight on the road). Then you can also see more details of the surface itself.

BTW I also just noticed the question is a bit odd. "What is the quality?" -> "Soft".
An answer for the quality would be "Good" or "bad" or so. I would not expect "soft" as an answer. Maybe change the question to "What is the stability?", or, as it has been suggested "...firmness". Yeah, maybe firmness is the best.

@westnordost

This comment has been minimized.

Copy link
Owner

westnordost commented Mar 28, 2018

It would be ideal to have the different photos more or less show the same scene and in the same perspective but only have the track types differ. If on one photo, there is a forest but on the others, there are just meadows and shrubbery, people might be confused that this photo should be selected for tracks in a forest.
The perspective is fine, IMO. As said, it should be the similar to the other photos.

ENT8R added some commits Apr 12, 2018

@ENT8R

This comment has been minimized.

Copy link
Contributor

ENT8R commented Apr 12, 2018

I changed the icon to the tractor now because the ways are mainly used by them. So it makes kinda sense to show it...
I also changed some images and rescaled all of them, so I would think that this PR is ready for another review...

@rugk

This comment has been minimized.

Copy link
Contributor

rugk commented Apr 12, 2018

because the ways are mainly used by them.

Only the bad ones, i.e. the ones with the bad quality. As this quest also can be answered with good quality/asks about the type in general, this argument makes no sense.

@ENT8R

This comment has been minimized.

Copy link
Contributor

ENT8R commented Apr 13, 2018

Well but for example the ways are allowed for (in German) "Land- und Forstwirtschaftliche Fahrzeuge" which implicites tractors... And I know also some tracks with a good surface quality like asphalt which can be used by tractors... I don't know which icon is the better one...

ENT8R added some commits May 15, 2018

@westnordost

This comment has been minimized.

Copy link
Owner

westnordost commented May 21, 2018

Here would be some more pictures that might fit: #133 (comment)

ENT8R added some commits Oct 8, 2018

Replace 3 images, update authors.txt and give it a higher priority be…
…cause some renderers need that information
@ENT8R

This comment has been minimized.

Copy link
Contributor

ENT8R commented Oct 8, 2018

I replaced the images of grade1, grade2 and grade4 with some of the images made by @BjornRasmussen in #133 (comment)
At least for me the difference between all of them is now pretty clear.
If you want to you can share your opinion!

@BjornRasmussen

This comment has been minimized.

Copy link

BjornRasmussen commented Oct 8, 2018

Nice use of the images!

@ENT8R

This comment has been minimized.

Copy link
Contributor

ENT8R commented Oct 8, 2018

Nice use of the images!

I'm not really sure if you released all images under the under the CC BY 4.0 license or only the images used for the path surface quest... Because I only found this comment where you stated that 6 images can be used but 2 of the images I used were mentioned earlier above and not in that comment. Would it be possible that you maybe release https://drive.google.com/file/d/1VzhiJin8IUIMFnQzOLeyDurttyeVPnbuXA/view and https://drive.google.com/file/d/1RJn5CW_AijVCWWtQ_cKHXmGFksTZ2ua9SQ/view under the same license too?

@BjornRasmussen

This comment has been minimized.

@westnordost

This comment has been minimized.

Copy link
Owner

westnordost commented Oct 9, 2018

The pics are really good now!

@rugk

This comment has been minimized.

Copy link
Contributor

rugk commented Oct 9, 2018

Maybe you can exclude tracks already tagged with "surface=asphalt" (if that is a thing/happens for "highway=track"), as there the track type value is quite obvious, it's level 1 and one would not need to ask a surveyor about that.

As for the images, yes, they show what we want, but what catches my eye first are actually the differences between the images regarding whether there are trees at the left/right. 😢
Maybe they can be edited away 😉
(And I still liked the original quest icon more than the 🚜)

@westnordost westnordost merged commit ff88115 into westnordost:master Oct 27, 2018

@ENT8R ENT8R deleted the ENT8R:tracktype branch Oct 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment