Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Discuss transaction ID (#1)
* Delete .DS_Store

* Remove TODO item: transaction_id

The transaction_id is only used by association tracking, so
it should be managed by the association tracking gem.
  • Loading branch information
jaredbeck authored and westonganger committed May 22, 2018
1 parent 37b91a4 commit 3915d4d
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
Binary file removed .DS_Store
Binary file not shown.
1 change: 1 addition & 0 deletions .gitignore
@@ -1,5 +1,6 @@
*.gem
*.sqlite3-journal
.DS_Store
.bundle
.byebug_history
.idea
Expand Down
9 changes: 4 additions & 5 deletions README.md
Expand Up @@ -7,10 +7,9 @@ paper_trail plugin to track and reify associations
## TODO

- Continue removing most-non association specs
- Decide what to do about transaction_id, It may be nice to leave this in paper_trail itself. Verify no statements regarding `transaction_id` were accidentally lost via initial cleanup commit
- Ensure all references to be `transaction_id` are properly patched.
- Improve Readme
- Add consolidated list of paper trail plugins to offical paper_trail readme

- Add consolidated list of paper trail plugins to official paper_trail readme

## Table of Contents

Expand Down Expand Up @@ -227,9 +226,9 @@ See [issue 113][16] for a discussion about this.

### ActiveRecord Single Table Inheritance (STI)

At this time during `reify` any STI `has_one` associations will raise a `PaperTrail::Reifiers::HasOne::FoundMoreThanOne` error. See https://github.com/airblade/paper_trail/issues/594
At this time during `reify` any STI `has_one` associations will raise a `PaperTrail::Reifiers::HasOne::FoundMoreThanOne` error. See https://github.com/airblade/paper_trail/issues/594

Something to note though, is while the offical PaperTrail gem supports [Single Table Inheritance][39], I dont recommend STI ever. Your better off rolling your own solution rather than using STI.
Something to note though, is while the offical PaperTrail gem supports [Single Table Inheritance][39], I dont recommend STI ever. Your better off rolling your own solution rather than using STI.


## Articles
Expand Down

0 comments on commit 3915d4d

Please sign in to comment.