Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more types #17

Closed
westonganger opened this issue Jul 15, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@westonganger
Copy link
Owner

commented Jul 15, 2016

When trying to add a float value it does not show.

I think the cause is on line 75 of lib/odf/cell.rb you basically only allow :string

Valid office:value-types are as follows :float, :percentage, :currency, :date, :time which you can read about here: http://books.evc-cit.info/books/odbook/ch05.html

I would be interested in helping maintain this gem such as accepting PR's, adding features like this one, and releasing new versions if your willing to give me the permissions.

@thiagoarrais

This comment has been minimized.

Copy link
Collaborator

commented Jul 18, 2016

That would be excellent, @westonganger. I've really wanderd off to other things and can't really maintain the gem properly. We can even make your fork the canonical one, change the gem's homepage, etc., if you'd like.

How can we do that without making it (too) confusing for people?

@westonganger

This comment has been minimized.

Copy link
Owner Author

commented Jul 18, 2016

I think the code should stay here in this repo. In my experience things can get confusing when moving repo's around, plus you have done tons of work here which you should get credit for.

I just want the ability to help get new features through, accept PR's, add documentation, and release new versions. If you are interested in this, you should be able to add people as Collaborators under the Settings tab of this repo.

@thiagoarrais

This comment has been minimized.

Copy link
Collaborator

commented Jul 18, 2016

Done. I've also added westonganger as gem owner in rubygems. You should be able to gem push now. Let me know if that isn't you.

@westonganger

This comment has been minimized.

Copy link
Owner Author

commented Dec 3, 2016

v1.0.0 automatically determines the correct type based on the value passed to cell if one wasnt specified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.