diff --git a/src/plugins/multimedia/multimedia.js b/src/plugins/multimedia/multimedia.js index 04bf6b13a49..25b98936130 100644 --- a/src/plugins/multimedia/multimedia.js +++ b/src/plugins/multimedia/multimedia.js @@ -14,8 +14,8 @@ var $document = $(document), $seed = 0, $templatetriggered = false, $lang = document.documentElement.lang, - formatTime, parseTime, expand, load_captions_external, load_captions_internal, - parseHtml, parseXml, playerapi, update_captions; + formatTime, parseTime, expand, loadCaptionsExternal, loadCaptionsInternal, + parseHtml, parseXml, playerapi, updateCaptions; /* helper functions*/ @@ -172,17 +172,22 @@ parseXml = function( content ) { return captions; }; -load_captions_external = function( elm, url ) { - return $.ajax({ +/* +@method loadCaptionsExternal +@description Loads captions from an external source (HTML embed or TTML) +@param {Object} elm The jQuery object for the multimedia player loading the captions +@param {String} url The url for the captions resource to load +*/ +loadCaptionsExternal = function( elm, url ) { + $.ajax({ url: url, - // FIXME: Where is "evtmgr" from? - context: evtmgr, dataType: "html", dataFilter: function( data ) { - return data.replace( /]*>/g, "" ); + //Filters out images and objects from the content to avoid loading them + return data.replace( /]*>/g, "" ); }, success: function( data ) { - return $( elm ).trigger({ + elm.trigger({ type: "captionsloaded.mediaplayer.wb", captions: data.indexOf( "= caption.begin && seconds <= caption.end ) { area.append( $( "
" + caption.text + "
" ) ); } - _results.push( counter += 1 ); } - return _results; }; + playerapi = function( fn, args ) { var $this, captionsArea, method; @@ -520,7 +537,7 @@ $document.on("durationchange play pause ended volumechange timeupdate captionslo .text( formatTime( this.player( "getCurrentTime" ) ) ); if ( $.data( event.target, "captions" ) !== undef ) { - update_captions( + updateCaptions( $this.find( ".wb-mm-captionsarea" ), this.player( "getCurrentTime" ), $.data( event.target, "captions" )