Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Found new error when validating with validator.w3.org #7291

Closed
crochefort opened this issue Dec 11, 2015 · 10 comments

Comments

Projects
None yet
7 participants
@crochefort
Copy link

commented Dec 11, 2015

try this :
https://validator.w3.org/nu/?useragent=Validator.nu%2FLV+http%3A%2F%2Fvalidator.w3.org%2Fservices&doc=http%3A%2F%2Fwet-boew.github.io%2Fv4.0-ci%2Ftheme%2Fcontent-secmenu-en.html

Error: Bad value search for attribute role on element form.

From line 70, column 1; to line 70, column 87

arch</h2>↩<form action="https://google.ca/search" method="get" role="search" class="form-inline">↩<div 
@LaurentGoderre

This comment has been minimized.

Copy link
Member

commented Dec 11, 2015

My best is that it's an issue with the validator....The aria spec specifically says you should use search
http://www.w3.org/TR/wai-aria/roles#form

@nschonni

This comment has been minimized.

Copy link
Member

commented Dec 11, 2015

There has been a bunch of discussion on the accessibility lists about this. Having the role=search directly on a form is currently an error, and you need to put the role on a container object. I guess it's probably because the search role probably clobbers the "form" role for AT.

@pjackson28

This comment has been minimized.

Copy link
Member

commented Dec 11, 2015

@nschonni Until that is clarified in the WAI-ARIA spec (still not in the latest 1.1 working draft), then the validator should not be identifying it as an error. The validator is getting bad for having stricter interpretations than the spec permits. For instance a common issue is the validatoris interpreting "DOM descendant" as meaning "child" for the owned element definition when the DOM specification states: "A descendant node of any node A is any node below A in a tree model, where "below" means "away from the root." (http://www.w3.org/TR/2004/REC-DOM-Level-3-Core-20040407/glossary.html#dt-descendant).

@pjackson28

This comment has been minimized.

Copy link
Member

commented Dec 11, 2015

Should also clarify that the same spec definition of child is "A child is an immediate descendant node of a node." So the validator's interpretation that child = descendant is incorrect where the correct interpretation would be that a child is a type of descendant. Hopefully the validator will get better at aligning with the specs (or if the issue is with the wording in spec, then the spec addresses the wording issues).

@nschonni

This comment has been minimized.

Copy link
Member

commented Dec 16, 2015

Applicable discussion thread w3c/wcag#113

@stevefaulkner

This comment has been minimized.

Copy link

commented Dec 16, 2015

bug on spec fixed re role=search w3c/html-aria#18 and validator bug filed

@LaurentGoderre

This comment has been minimized.

Copy link
Member

commented Dec 16, 2015

@stevefaulkner great to hear from you! Thanks!

@hsrudnicki

This comment has been minimized.

Copy link

commented Jan 29, 2016

Based on last comments, can be this issue closed as resolved/fixed or if otherwise? Either way, please update again this issue's status, thank you

@EricDunsworth

This comment has been minimized.

Copy link
Member

commented Feb 1, 2016

@hsrudnicki @LaurentGoderre Should this issue remain open until the NU validator stops producing that error?

Btw I've followed up in validator/validator#193 about the validator itself.

@LaurentGoderre

This comment has been minimized.

Copy link
Member

commented Feb 2, 2016

I don't think so because it's not an actual issue on our side. If someone opens a new issue, we will close and reference this issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.