Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form buttons and dropdown list element are cut off at 200% #8492

Closed
fredymoko opened this issue Oct 12, 2018 · 6 comments · Fixed by #8686
Closed

Form buttons and dropdown list element are cut off at 200% #8492

fredymoko opened this issue Oct 12, 2018 · 6 comments · Fixed by #8686

Comments

@fredymoko
Copy link

On this page: http://wet-boew.github.io/themes-dist/GCWeb/feedback-en.html,
all form buttons and dropdown list are cut off at 200% due to the absolute length units:
input[type="button"], input[type="reset"], input[type="submit"] {
height: 37px;
}

.form-control {
height: 37px;
}

zoom_200_percent
form_control
form_submit

@ghost
Copy link

ghost commented Nov 7, 2018

I could not reproduce on the latest Firefox as it appears you're using that browser.

Firefox:
screen shot 2018-11-07 at 4 27 08 pm

Firefox Version 63.0.1

@fredymoko
Copy link
Author

fredymoko commented Nov 8, 2018

I'm using Firefox Quantum too. To reproduce the issue, in View>Zoom, please check "Zoom Text Only"

zoom text only checked

@ghost
Copy link

ghost commented Nov 8, 2018

Yes with Zoom Test Only the enforced height causes the issue. I wonder if using min-height would fix it without causing any issues on other browsers.

Looking a the scss files it appears this is not a wet override, but coming directly from bootstrap.

See https://github.com/wet-boew/wet-boew/blob/1882dd3df9cefb0d8d64edb22783903ace778edd/src/base/bootstrap-overrides/_base.scss for bootstrap overrides.

@ghost
Copy link

ghost commented Nov 8, 2018

There are other open issues too #7744 and #6910 with suggested ways to fix.

The better solution seems to be #7744 (comment).

@nricherbrule
Copy link

@bsouster Other tickets exist focusing on this issue. I think this can be closed.

@duboisp duboisp moved this from Backlog to Ready to be worked on in Accessibility Jul 9, 2019
grifare added a commit to grifare/wet-boew that referenced this issue Jul 11, 2019
Addresses the issue wet-boew#8492. Fixes the elements using this class.
grifare added a commit to grifare/wet-boew that referenced this issue Jul 11, 2019
grifare added a commit to grifare/wet-boew that referenced this issue Jul 12, 2019
@grifare
Copy link
Member

grifare commented Jul 12, 2019

I have applied the fixes pointed out on this discussion to overwrite the existing rules and they worked. Tested IE11, Microsoft Edge 42, Firefox 57 (using zoom text only), and Chrome 75.

duboisp pushed a commit that referenced this issue Jul 17, 2019
…8686)

* CSS: added 2 rules to the form-control class

Addresses the issue #8492. Fixes the elements using this class.

* CSS: added 2 rules to input element

Addresses the issue #8492

Approved at the technical review meeting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Accessibility
  
Ready to be worked on
Development

Successfully merging a pull request may close this issue.

4 participants