feat: multicall chunk size #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a3089ad The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +494 B (0%) Total Size: 252 kB
ℹ️ View Unchanged
|
Codecov Report
@@ Coverage Diff @@
## main #398 +/- ##
==========================================
- Coverage 99.93% 95.14% -4.80%
==========================================
Files 267 264 -3
Lines 22610 22026 -584
Branches 1914 1706 -208
==========================================
- Hits 22596 20957 -1639
- Misses 14 1064 +1050
- Partials 0 5 +5
... and 47 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jxom
force-pushed
the
jxom/multicall-chunk-size
branch
from
1c08024
to
56b2ccf
Compare
tmm
reviewed
Apr 24, 2023
| - **Type:** `number` | ||
| - **Default:** [`client.batch.multicall.batchSize`](/docs/clients/public.html#batch-multicall-batchsize-optional) (if set) or `1024` | ||
|
|
||
| The maximum size (in bytes) for each calldata chunk. Set to `0` to disable the size limit. |
There was a problem hiding this comment.
Worth popping in a sentence about what smaller versus larger numbers mean (like the trade off)?
src/actions/public/multicall.test.ts
Outdated
| @@ -621,3 +622,47 @@ test('multicall contract deployed on later block', async () => { | |||
| Version: viem@1.0.2" | |||
| `) | |||
| }) | |||
|
|
|||
| test.only('stress', async () => { | |||
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR adds a new
batchSizeparameter tomulticallwhich limits the size of each calldata chunk. It also includes documentation updates and tests.Detailed summary
batchSizeparameter tomulticallfunctionmulticallandpublicClientmulticallfunction withbatchSizeparameter andpublicClientwithbatchSizeparameter set in batch configuration