From 0074ef183d11891761b87b910cef515e8b98e6bd Mon Sep 17 00:00:00 2001 From: Guy Baron Date: Fri, 9 Aug 2019 12:43:02 +0300 Subject: [PATCH] removed logging a warning when worker message channel returns an error --- gbus/worker.go | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/gbus/worker.go b/gbus/worker.go index 4c6f5b0..367449f 100644 --- a/gbus/worker.go +++ b/gbus/worker.go @@ -5,12 +5,13 @@ import ( "database/sql" "errors" "fmt" - "github.com/wework/grabbit/gbus/metrics" "math/rand" "runtime/debug" "sync" "time" + "github.com/wework/grabbit/gbus/metrics" + "github.com/Rican7/retry" "github.com/Rican7/retry/backoff" "github.com/Rican7/retry/jitter" @@ -126,8 +127,6 @@ func (worker *worker) consumeMessages() { if shouldProceed { worker.processMessage(delivery, isRPCreply) - } else { - worker.log().WithField("message_id", delivery.MessageId).Warn("no proceed") } } @@ -388,7 +387,7 @@ func (worker *worker) invokeHandlers(sctx context.Context, handlers []MessageHan } ctx.SetLogger(worker.log().WithField("handler", handler.Name())) handlerErr = metrics.RunHandlerWithMetric(func() error { - return handler(ctx, message) + return handler(ctx, message) }, handler.Name(), worker.log()) if handlerErr != nil { hspan.LogFields(slog.Error(handlerErr))