-
-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bell event triggers too much #5985
Comments
As per the comment in mod.rs, bell events are sent to all windows; not just the window containing the pane which generated the event. To prevent each bell ringing multiple times, the window event handler must check if it has the pane, and ignore the bell event if it doesn't. This fixes bug wez#5985
* Restrict bell events to the proper window. As per the comment in mod.rs, bell events are sent to all windows; not just the window containing the pane which generated the event. To prevent each bell ringing multiple times, the window event handler must check if it has the pane, and ignore the bell event if it doesn't. This fixes bug #5985 Co-authored-by: Sean Estabrooks <sean.estabrooks@eztux.com>
This should be resolved now in It typically takes about an hour before commits are available as nightly builds for all platforms. Linux builds are the fastest to build and are often available within about 20 minutes. Windows and macOS builds take a bit longer. Please take a few moments to try out the fix and let me know how that works out. You can find the nightly downloads for your system in the wezterm installation docs. If you prefer to use packages provided by your distribution or package manager of choice and don't want to replace that with a nightly download, keep in mind that you can download portable packages (eg: a If you are eager and can build from source then you may be able to try this out more quickly. |
This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further. |
What Operating System(s) are you seeing this problem on?
Linux X11
Which Wayland compositor or X11 Window manager(s) are you using?
X11 with AwesomeWM as window manager
WezTerm version
20240812.215703.30345b36
Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?
Yes, and I updated the version box above to show the version of the nightly that I tried
Describe the bug
Whenever a BEL character is being printed (
'\a'
/'\007'
/'\x07'
), the bells rings multiple times, I noticed it rings the exact same amount of times as the count of opened wezterm windows.To Reproduce
printf "\a"
Configuration
no config
Expected Behavior
The bell only rings once.
Logs
Anything else?
I added the following to log the bell occurrences, but the problem is the same whether or not I have a config file:
The problem isn't the audible bell, but the actual bell event, because both trigger the same amount of times.
My current workaround is to disable the builtin bell, and manually run the xkbbell command to trigger the X11 bell, but only if the window id is 0 (to avoid triggering multiple times):
The text was updated successfully, but these errors were encountered: