-
Notifications
You must be signed in to change notification settings - Fork 48
UI for flexible routines #975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package.json # yarn.lock
This is only used to show the current workout day, and is not edited in any way
This is only used when submitting exercises, and we will probably need a new one that simply handles known exercises throughout the application
# Conflicts: # src/services/workoutLogs.test.ts
instead of loading the same data from the server
but only when visiting the appropriate pages
The docs are being consolidated in readthedocs
Also replace the useRoutineLogQuery with useRoutineLogData (which is cached) in workoutLogs.ts
Not sure why this is happening, perhaps when there are logs with exercises that are not in the plan or something like that?
There is a separate list for this
This makes the behaviour consistent with the mobile app. We still have to figure out how to communicate that there are "hidden" rest days, but perhaps this is not so important after all
# Conflicts: # package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.