Feature/body weight chart filter 1696 #988
Conversation
| variant={currentFilter === '' ? 'contained' : 'outlined'} | ||
| sx={{ fontFamily: theme.typography.fontFamily }} | ||
| > | ||
| All |
There was a problem hiding this comment.
can you make the labels translatable? Just add them to public/locales/en/translation.json and then you can just use them with {t('key')}. Just add them to the root, these could potentially be also used soemwhere else in the application
There was a problem hiding this comment.
Of course! I've updated the code based on your feedback.
src/services/weight.ts
Outdated
| export const getWeights = async (): Promise<WeightEntry[]> => { | ||
| const url = makeUrl(WEIGHT_PATH, { query: { ordering: '-date', limit: 900 } }); | ||
| export const getWeights = async (filter: FilterType = ''): Promise<WeightEntry[]> => { | ||
| const url = makeUrl(WEIGHT_PATH, { query: { ordering: '-date', limit: 900, filter } }); |
There was a problem hiding this comment.
sorry I forgot one more! The backend doesn't currently understand the filter parameter, but we can calculate the date based on it and pass it like this 'date_gte': <iso-date-string>
There was a problem hiding this comment.
I have also modified the backend to support the filter and linked the pull request to the issue, alongside this one. Would you prefer the solution I provided, or would you like me to adjust it according to your suggestion and leave the backend unchanged?
There was a problem hiding this comment.
I saw that after I wrote this 😄. I think putting the specific date is better since it's more explicit and we don't need a special syntax for that (you'll need to pull master for this BTW)
|
awesome, thank you! |
3 participants
Proposed Changes
Related Issue
Please check that the PR fulfills these requirements