fixes #3; match var names in README & index.html #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if(/^[0-9]+$/.test(str)) { | ||
| return Number(str); | ||
| } | ||
| return NaN; | ||
| } | ||
|
|
||
| function parseNat (str) { | ||
| if(/^[0-9]+$/.test(str) && Number(str) !== 0) { |
There was a problem hiding this comment.
how about just:
var whole = parseWhole(str);
return whole === 0 ? NaN : whole;
to avoid code duplication?
|
@wgreenberg good call |
wgreenberg
added a commit
that referenced
this pull request
Jul 24, 2015
fixes #3; match var names in README & index.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3
Solution:
Also, the variable names in the README's instructions were different than the ones in index.html so I synced them up.