factorial from math

[zsrinivas]

importing factorial from math

[sublee]

Thanks to patch but the test failed.

Anyway, the factorial function doesn't matter in the test code. It's just a simplest example to test profiling results clearly. We can replace it with any other example.

[zsrinivas]

👍

[coveralls]

Coverage decreased (-0.04%) when pulling fcb8dd0 on eightnoteight:master into 810da9b on what-studio:master.

[zsrinivas]

I think the tests has to be changed for this one..

[coveralls]

Coverage decreased (-0.04%) when pulling fcb8dd0 on eightnoteight:master into 810da9b on what-studio:master.

[sublee]

Thanks to patch and comment again.

But I still couldn't understand why the test has to use math.factorial. Shall you explain the reason?

[zsrinivas]

I'm terribly sorry for wasting your time on this,
after your yesterday's comment i wanted to close this and about my comment,
simply because it is fast and written in C and when you are in python3 it is even faster because of algo implementation see this.
BUT all this doesn't matter for the practical purpose of this program.
Sorry again!
I have already tried to close this.(in a very fuzzy way)

[sublee]

Oh, don't sorry for this. I thank for your cooperation. If the factorial's speed be a problem at the future, I'll remind your advice. Thanks again.