Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Say that -webkit-appearance must be supported #104

Merged
merged 3 commits into from Aug 27, 2018

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Aug 27, 2018

Also say that appearance must not be supported.

Also say that appearance must not be supported.
@zcorpan zcorpan requested a review from miketaylr August 27, 2018 17:32
Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

compatibility.bs Outdated
@@ -502,6 +502,12 @@ The following <code>-webkit-</code> <a>vendor prefixed</a> properties must be su
<br>
<div class="note">As soon as each property is unprefixable it can be defined as a "simple" alias.</div>

<h4 id="css-non-alias">Non-alias vendor prefixed properties</h4>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "non-aliased" reads as more natural, at least to me. But I could be convinced either way.

(unless non-alias is the more commonly used technical term i'm not familiar with)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(feel free to change and merge after -- or just merge if you think non-alias is better here)

@miketaylr
Copy link
Member

I guess we want to have some wpt as well -- I thought we did for -webkit-appearance, but I see that was backed out: web-platform-tests/wpt@4981a13#diff-6805d2eb09708dde50e925b430024691

zcorpan added a commit to web-platform-tests/wpt that referenced this pull request Aug 27, 2018
@zcorpan
Copy link
Member Author

zcorpan commented Aug 27, 2018

PTAL

Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as long as we keep the list up to date with what the intersection of what Gecko and Blink/WebKit implement is (and Edge?). I think we'll have a better idea as your research in this area progresses of what to add or remove over time.

edit: I see https://github.com/web-platform-tests/wpt/pull/12700/files#diff-1dc558b0c805c24c530a22e254e454d6R8, so that's cool.

cc @jwatt

@zcorpan zcorpan merged commit c497226 into master Aug 27, 2018
@zcorpan zcorpan deleted the zcorpan/webkit-appearance branch August 27, 2018 19:40
zcorpan added a commit to web-platform-tests/wpt that referenced this pull request Aug 27, 2018
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Aug 31, 2018
…arance properties, a=testonly

Automatic update from web-platform-testsCompat: Test -webkit-appearance and appearance properties

See whatwg/compat#104

--

wpt-commits: 5d94e928e6e04c7506b11c8b10fcd7a9caffac82
wpt-pr: 12700
jankeromnes pushed a commit to jankeromnes/gecko that referenced this pull request Aug 31, 2018
…arance properties, a=testonly

Automatic update from web-platform-testsCompat: Test -webkit-appearance and appearance properties

See whatwg/compat#104

--

wpt-commits: 5d94e928e6e04c7506b11c8b10fcd7a9caffac82
wpt-pr: 12700
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 3, 2019
…arance properties, a=testonly

Automatic update from web-platform-testsCompat: Test -webkit-appearance and appearance properties

See whatwg/compat#104

--

wpt-commits: 5d94e928e6e04c7506b11c8b10fcd7a9caffac82
wpt-pr: 12700

UltraBlame original commit: 069971381d90dae4091924fdce90db18b16846c9
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 3, 2019
…arance properties, a=testonly

Automatic update from web-platform-testsCompat: Test -webkit-appearance and appearance properties

See whatwg/compat#104

--

wpt-commits: 5d94e928e6e04c7506b11c8b10fcd7a9caffac82
wpt-pr: 12700

UltraBlame original commit: 069971381d90dae4091924fdce90db18b16846c9
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 3, 2019
…arance properties, a=testonly

Automatic update from web-platform-testsCompat: Test -webkit-appearance and appearance properties

See whatwg/compat#104

--

wpt-commits: 5d94e928e6e04c7506b11c8b10fcd7a9caffac82
wpt-pr: 12700

UltraBlame original commit: 069971381d90dae4091924fdce90db18b16846c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants