New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Say that -webkit-appearance must be supported #104

Merged
merged 3 commits into from Aug 27, 2018

Conversation

2 participants
@zcorpan
Member

zcorpan commented Aug 27, 2018

Also say that appearance must not be supported.

Say that -webkit-appearance must be supported
Also say that appearance must not be supported.

@zcorpan zcorpan requested a review from miketaylr Aug 27, 2018

@miketaylr

Thanks!

Show outdated Hide outdated compatibility.bs
@miketaylr

This comment has been minimized.

Show comment
Hide comment
@miketaylr

miketaylr Aug 27, 2018

Collaborator

I guess we want to have some wpt as well -- I thought we did for -webkit-appearance, but I see that was backed out: web-platform-tests/wpt@4981a13#diff-6805d2eb09708dde50e925b430024691

Collaborator

miketaylr commented Aug 27, 2018

I guess we want to have some wpt as well -- I thought we did for -webkit-appearance, but I see that was backed out: web-platform-tests/wpt@4981a13#diff-6805d2eb09708dde50e925b430024691

zcorpan added a commit to web-platform-tests/wpt that referenced this pull request Aug 27, 2018

@zcorpan

This comment has been minimized.

Show comment
Hide comment
@zcorpan

zcorpan Aug 27, 2018

Member

PTAL

Member

zcorpan commented Aug 27, 2018

PTAL

@miketaylr

LGTM, as long as we keep the list up to date with what the intersection of what Gecko and Blink/WebKit implement is (and Edge?). I think we'll have a better idea as your research in this area progresses of what to add or remove over time.

edit: I see https://github.com/web-platform-tests/wpt/pull/12700/files#diff-1dc558b0c805c24c530a22e254e454d6R8, so that's cool.

cc @jwatt

@zcorpan zcorpan merged commit c497226 into master Aug 27, 2018

2 checks passed

Participation zcorpan participates on behalf of Bocoup LLC
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zcorpan zcorpan deleted the zcorpan/webkit-appearance branch Aug 27, 2018

zcorpan added a commit to web-platform-tests/wpt that referenced this pull request Aug 27, 2018

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Aug 31, 2018

Bug 1486548 [wpt PR 12700] - Compat: Test -webkit-appearance and appe…
…arance properties, a=testonly

Automatic update from web-platform-testsCompat: Test -webkit-appearance and appearance properties

See whatwg/compat#104

--

wpt-commits: 5d94e928e6e04c7506b11c8b10fcd7a9caffac82
wpt-pr: 12700

jankeromnes pushed a commit to jankeromnes/gecko that referenced this pull request Aug 31, 2018

Bug 1486548 [wpt PR 12700] - Compat: Test -webkit-appearance and appe…
…arance properties, a=testonly

Automatic update from web-platform-testsCompat: Test -webkit-appearance and appearance properties

See whatwg/compat#104

--

wpt-commits: 5d94e928e6e04c7506b11c8b10fcd7a9caffac82
wpt-pr: 12700
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment