New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta: update repository files #169
Meta: update repository files #169
Conversation
See https://github.com/whatwg/spec-factory for details.
See whatwg/spec-factory#1 for some discussion on the |
.editorconfig
Outdated
@@ -4,10 +4,13 @@ root = true | |||
end_of_line = lf | |||
insert_final_newline = true | |||
charset = utf-8 | |||
indent_size = 2 | |||
indent_size = 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this change cause any changes in the actual spec? If so, should we be including it as part of this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good question. Happy to leave that out this round, but I do think it would be good for Console to align on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I meant should we be including the changes to the spec as part of this. I don't use editorconfig, so it will take me a bit to find out myself, and it's clear I should already be sleeping. ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If someone is willing to reformat the specification we could include that change here I suppose, but it might be better as a distinct commit.
I tend to agree that we should keep the editorconfig and the spec itself in sync. |
See https://github.com/whatwg/spec-factory for details.