Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: update repository files #169

Merged

Conversation

annevk
Copy link
Member

@annevk annevk commented Apr 1, 2020

@annevk
Copy link
Member Author

annevk commented Apr 1, 2020

See whatwg/spec-factory#1 for some discussion on the .editorconfig changes.

.editorconfig Outdated
@@ -4,10 +4,13 @@ root = true
end_of_line = lf
insert_final_newline = true
charset = utf-8
indent_size = 2
indent_size = 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change cause any changes in the actual spec? If so, should we be including it as part of this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good question. Happy to leave that out this round, but I do think it would be good for Console to align on this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant should we be including the changes to the spec as part of this. I don't use editorconfig, so it will take me a bit to find out myself, and it's clear I should already be sleeping. ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone is willing to reformat the specification we could include that change here I suppose, but it might be better as a distinct commit.

@domenic
Copy link
Member

domenic commented Apr 1, 2020

I tend to agree that we should keep the editorconfig and the spec itself in sync.

.editorconfig Outdated Show resolved Hide resolved
@annevk annevk requested a review from domenic April 1, 2020 12:59
@domfarolino domfarolino merged commit ddaa206 into master Apr 1, 2020
@domfarolino domfarolino deleted the meta-template/bb51deca-73e9-11ea-a571-989e633d1b1a branch April 1, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants