Permalink
Commits on Aug 8, 2018
  1. Make the DOMTokenList creation steps use "get an attribute value"

    TRowbotham authored and annevk committed Aug 8, 2018
    This makes it so that if a DOMTokenList's associated element has an attribute that is the associated attribute's local name, at creation time, it will use the "get an attribute value" steps, which will always return a string. Previously, the this used the "get an attribute by namespace and local name" steps, which would return an Attr node if the associated element had an attribute that is the associated attribute's local name.
    
    Fixes #666.
Commits on Jun 21, 2018
  1. Review Draft Publication: June 2018

    annevk authored and domenic committed Jun 21, 2018
  2. Add toggleAttribute() to Element

    jonathanKingston authored and annevk committed Jun 21, 2018
    Tests: see https://bugzilla.mozilla.org/show_bug.cgi?id=1469592. Will be upstreamed soonish.
    
    Fixes #461.
Commits on Jun 7, 2018
  1. Standardize window.event

    miketaylr and annevk committed Jun 7, 2018
    Too many people like their global variables.
    
    Tests: web-platform-tests/wpt#4790 & web-platform-tests/wpt#10329.
    
    Fixes #334.
    
    Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
Commits on May 29, 2018
  1. Meta: Review Draft infrastructure

    annevk authored and domenic committed May 29, 2018
    See whatwg/whatwg.org#197 and whatwg/meta#92 for details.
    
    This also updates the web-platform-tests and IRC URLs.
Commits on May 22, 2018
  1. Meta: fix link to the DOM Standard twitter page

    Zirro authored and annevk committed May 22, 2018
    It's thedomstandard, rather than domstandard.
Commits on May 18, 2018
  1. No longer allow the context object to be omitted

    annevk committed May 18, 2018
    It's never really unambiguous to omit it.
Commits on Apr 30, 2018
  1. Introduce "remove all event listeners" primitive

    annevk committed Apr 30, 2018
    This is needed for document.open(): whatwg/html#2302.
Commits on Apr 21, 2018
Commits on Apr 16, 2018
Commits on Apr 10, 2018
  1. Note retargeting usage in Fullscreen

    annevk committed Apr 9, 2018
    Mostly so I remember it's not just events.
    
    Fixes #620.
Commits on Apr 9, 2018
  1. Editorial: cleanup TreeWalker

    annevk committed Mar 23, 2018
    Make the formatting consistent, avoid use of goto and labels, and be more clear about where various concepts are stored.
  2. Fix TreeWalker's nextNode()

    annevk committed Apr 9, 2018
  3. Add more domintro boxes for Element

    annevk committed Apr 9, 2018
    Fixes #448.
  4. Editorial: minor cleanup

    annevk committed Apr 9, 2018
    Use "the context object" and "when invoked" more consistently.
  5. Define Event's srcElement and returnValue

    miketaylr authored and annevk committed Mar 30, 2018
    Unfortunately the web depends on these. They are intentionally
    defined in such a way to not offer capabilities beyond the
    non-historical API for events.
    
    Tests: web-platform-tests/wpt#10258.
    
    Fixes #625 and fixes #627.
Commits on Apr 6, 2018
  1. Define event constructing steps

    annevk committed Apr 6, 2018
    This hook can be used by complex Event subclasses, such as KeyboardEvent and TouchEvent, to initialize their internal state upon creation.
    
    Follow-up: w3c/uievents#194 and w3c/touch-events#94.
    
    Fixes #414.
Commits on Mar 30, 2018
Commits on Mar 29, 2018
Commits on Mar 28, 2018
  1. Shadow: fix event dispatch

    annevk committed Mar 28, 2018
    This makes a number of large changes to event dispatch:
    
    * The algorithm can no longer return early with true. The observable
      aspect is that the event object is "uninitialized" and false might 
      be returned if the event object was already canceled.
    * It accounts for Touch Events in shadow trees by adding the 
      "touch target list" which is somewhat similar to relatedTarget.
    * Retargeting for event targets is now solely controlled by the event 
      dispatch algorithm. The hook for other specifications is removed.
    * Retargeting now properly accounts for non-node objects.
    * Dispatch in general accounts for non-node objects too now.
    * If targets need to be unset to prevent exposure of a shadow tree
      this is now calculated prior to invoking listeners.
    
    Initializing relatedTarget and "touch target list" is up to the event
    classes that need it. #614 will add "event constructing steps" that
    enable this.
    
    Tests: web-platform-tests/wpt#9919
    (probably still needs work given today's changes)
    
    This closes #402, fixes #561, fixes #562, fixes #580, and fixes #602.
Commits on Mar 27, 2018
  1. Editorial: remove object argument from inner invoke

    annevk committed Mar 27, 2018
    Also address a couple minor formatting nits.
    
    Fixes #618.
Commits on Mar 23, 2018
  1. Editorial: ShadowRoot is sufficiently upstreamed

    annevk committed Mar 23, 2018
    Remove:
    
    * the reference to https://w3c.github.io/webcomponents/spec/shadow/
    * the reference to legacy DOM bugs
    * the idea of changing createElement for non-HTML documents.
Commits on Mar 22, 2018
  1. Editorial: expose surroundContents() comment

    annevk committed Mar 22, 2018
    Also align the formatting of that algorithm a bit.
    
    Fixes #250.
Commits on Mar 17, 2018
  1. Editorial: grammar fix

    annevk committed Mar 17, 2018
Commits on Mar 16, 2018
  1. Editorial: fix several issues with traversal

    annevk committed Mar 13, 2018
    Fixes the parts of #87 I understand.
  2. Editorial: be more consistent with callbacks

    annevk committed Mar 16, 2018
    Also address some Bikeshed nits.
  3. Remove additions from the historical section

    annevk committed Mar 16, 2018
    And perform some minor cleanup elsewhere.
    
    Fixes #394.
  4. Add AbstractRange and StaticRange

    annevk committed Mar 16, 2018
    This refactors large parts of the DOM Standard to reclassify Range
    objects as "live ranges" rather than "ranges". The bits shared
    between StaticRange and Range objects are put on a shared superclass
    named AbstractRange.
    
    This also introduces a "collapsed" definition and uses it throughout.
    
    It does not contain everything from
    https://w3c.github.io/staticrange/. I based this draft on the IDL
    present in implementations, coupled with the desire for a superclass.
    Extensions beyond this seem best addressed as follow-ups.
    
    Tests: web-platform-tests/wpt#9967.
    
    See also w3c/staticrange#1.
  5. Make the two ways of event creation share a path

    annevk committed Mar 16, 2018
    This introduces the "inner event creation steps" so we don't duplicate a bunch of logic. It also inlines timeStamp recommendations about clock resolution.
Commits on Mar 15, 2018
  1. A node doesn't have an associated tree

    annevk committed Mar 15, 2018
    It's better to talk about its root and then go through the (inclusive) descendants.
    
    Fixes #526.
Commits on Mar 14, 2018
  1. Editorial: add "add an event listener" hook

    annevk committed Mar 14, 2018
    This hook ensures that any special casing in addEventListener() is shared with event handlers. This commit also makes numerous editorial improvements that were long overdue around dictionary members.
    
    The corresponding change to the HTML Standard, which defines event handlers, is tracked by whatwg/html#3561.
    
    This helps with #365 and w3c/ServiceWorker#1004. (Tests will be added as part of #365 eventually.)
Commits on Mar 13, 2018
  1. Stop defining nodeName in terms of tagName

    annevk committed Mar 13, 2018
    Fixes #297.