Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag refs in preventDefault()'s description missing "context object’s" qualifier #627

Closed
cvrebert opened this Issue Apr 6, 2018 · 1 comment

Comments

2 participants
@cvrebert
Copy link
Member

commented Apr 6, 2018

https://dom.spec.whatwg.org/commit-snapshots/07c110c87b8e4b1f7ecae09727b859bb75b17a73/#dom-event-preventdefault

The preventDefault() method, when invoked, must set the canceled flag if the cancelable attribute value is true and the in passive listener flag is unset.

Compared to the rest of the spec, this seems to me to be the only place that refers to "the X flag" (twice) rather than "context object’s X flag", in relation to a DOM event's flags.

@annevk annevk added the topic: events label Apr 6, 2018

@annevk

This comment has been minimized.

Copy link
Member

commented Apr 6, 2018

Thanks, I might solve this as part of #626 by making this share an algorithm with returnValue.

annevk added a commit to miketaylr/dom that referenced this issue Apr 9, 2018

Define Event's srcElement and returnValue
Unfortunately the web depends on these. They are intentionally
defined in such a way to not offer capabilities beyond the
non-historical API for events.

Tests: web-platform-tests/wpt#10258.

Fixes whatwg#625 and fixes whatwg#627.

@annevk annevk closed this in e36b369 Apr 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.