New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response.redirect() results in status message still being OK? #664

Closed
domenic opened this Issue Jan 19, 2018 · 4 comments

Comments

2 participants
@domenic
Member

domenic commented Jan 19, 2018

https://fetch.spec.whatwg.org/commit-snapshots/9862bc5923c32b070486f27a22a0c3d8a61cb5d0/#response-class

Set r’s response’s status to status.

r's response's status message never gets changed from the default `OK`. Is that correct?

In Firefox and Chrome it does appear that

Response.redirect("https://example.com/", 301).statusText === "OK"

which is kinda weird.

@annevk

This comment has been minimized.

Member

annevk commented Jan 20, 2018

I guess we should try make it the empty string, to align with H/2. It doesn't really matter what it is, but I agree that this is weird.

@annevk

This comment has been minimized.

Member

annevk commented Jan 20, 2018

#600 would probably fix this, but that was not intentional so that PR might require more scrutiny.

@annevk

This comment has been minimized.

Member

annevk commented Apr 12, 2018

Safari already returns the empty string, which seems way better. Edge also does OK unfortunately.

@annevk

This comment has been minimized.

Member

annevk commented Apr 12, 2018

Bugs filed: #600 (comment).

annevk added a commit to web-platform-tests/wpt that referenced this issue Apr 24, 2018

@annevk annevk closed this in 0dec453 Apr 24, 2018

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue May 2, 2018

Bug 1453623 [wpt PR 10442] - Fetch: expand Response.redirect() assert…
…ions, a=testonly

Automatic update from web-platform-testsFetch: expand Response.redirect() assertions

Needed for whatwg/fetch#664 and whatwg/fetch#600.

--

wpt-commits: 507af0c03617714bfd4134c54da4d534906ee52b
wpt-pr: 10442

mykmelez pushed a commit to mozilla/gecko that referenced this issue May 3, 2018

Bug 1453623 [wpt PR 10442] - Fetch: expand Response.redirect() assert…
…ions, a=testonly

Automatic update from web-platform-testsFetch: expand Response.redirect() assertions

Needed for whatwg/fetch#664 and whatwg/fetch#600.

--

wpt-commits: 507af0c03617714bfd4134c54da4d534906ee52b
wpt-pr: 10442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment