Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort refactoring led to variable errors #706

Closed
annevk opened this issue Apr 17, 2018 · 0 comments

Comments

@annevk
Copy link
Member

commented Apr 17, 2018

While working on #705 I noticed that because large swaths of code are now inside a conditional, sometimes variables get defined within that conditional that later on get referenced, except that doesn't work due to block scoping.

E.g., in https://fetch.spec.whatwg.org/#concept-http-network-or-cache-fetch storedResponse is now defined in a substep of step 2 and then referenced in a substep of step 4. That doesn't work.

@jakearchibald I'd appreciate if you could sort this, but let me know if you're too busy.

jakearchibald added a commit that referenced this issue May 30, 2018

@annevk annevk closed this in 3055f13 May 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.