Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure scheme fetch always returns a response with an actual body #1505

Merged
merged 2 commits into from
Oct 21, 2022

Conversation

annevk
Copy link
Member

@annevk annevk commented Oct 20, 2022

Helps with #1504.


Preview | Diff

@annevk annevk requested a review from domenic October 20, 2022 15:22
annevk added a commit that referenced this pull request Oct 20, 2022
Copy link
Member

@andreubotella andreubotella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -4569,7 +4569,8 @@ steps:
"<code>blank</code>", then return a new <a for=/>response</a> whose
<a for=response>status message</a> is `<code>OK</code>`, <a for=response>header list</a> is «
(`<code>Content-Type</code>`, `<code>text/html;charset=utf-8</code>`) », and
<a for=response>body</a> is the empty byte sequence.
<a for=response>body</a> is the <a for="body with type">body</a> of the result of
<a for=BodyInit>safely extracting</a> the empty byte sequence.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A shortcut for this would be appreciated, for use in HTML as well. Basically body-from-byte-sequence. It looks like you could use it below too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetch.bs Show resolved Hide resolved
@annevk annevk merged commit 813788a into main Oct 21, 2022
@annevk annevk deleted the annevk/scheme-fetch-bodies branch October 21, 2022 06:57
annevk added a commit that referenced this pull request Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants