Add Accept-CH-lifetime cache and CH header handling #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igrigorik
reviewed
May 22, 2018
| <li><dfn id=concept-accept-ch-cache-client-hints-list for=accept-ch-cache>client-hints list</dfn> | ||
| </ul> | ||
|
|
||
| <p>Entries must be removed after the seconds specified in the |
There was a problem hiding this comment.
Do we need any extra clauses to ensure that this cache is purged when user clears site-data or similar?
There was a problem hiding this comment.
@mikewest what's the best way to hook this to clear-site-data and similar UI concepts (e.g. user cleared their cookies)? Looking at https://w3c.github.io/webappsec-clear-site-data/#clear-dom it seems to enumerate all the relevant things that need to be cleared? Should the ACHL cache do the same?
| @@ -2897,6 +2936,19 @@ with a <i>CORS flag</i> and <i>recursive flag</i>, run these steps: | |||
| <li><p><a href=https://w3c.github.io/webappsec-csp/#set-response-csp-list>Set <var>internalResponse</var>'s CSP list</a>. | |||
| [[!CSP]] | |||
|
|
|||
| <li><p>If <var>response</var>'s | |||
| <a href=http://httpwg.org/http-extensions/client-hints.html#accept-ch>Accept-CH header</a> | |||
| is present, process the header and add its client-hints tokens to the <a>active document</a>'s | |||
| <li><p>If <var>response</var>'s | ||
| <a href=http://httpwg.org/http-extensions/client-hints.html#accept-ch-lifetime>Accept-CH-Lifetime header</a> | ||
| is present, call | ||
| <a for=accept-ch-cache>create a new entry</a> with <var>response</var>'s <var>origin</var>, the |
10 tasks
|
Superseded by whatwg/html#3774 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the concept of an Accept-CH cache as well as some handling for the
Accept-CHandAccept-CH-Lifetimeheaders.Tackles some of the concepts that need defining in #726
Preview | Diff