Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be strict on request's Content-Type #829

Merged
merged 1 commit into from Nov 9, 2018

Conversation

2 participants
@annevk
Copy link
Member

commented Nov 5, 2018

Tests: web-platform-tests/wpt#13921.

Helps with #814.

<li><p>If <var>mimeType</var>'s <a for="MIME type">essence</a> is not
"<code>application/x-www-form-urlencoded</code>", "<code>multipart/form-data</code>", or
"<code>text/plain</code>", then return false.
</ol>

This comment has been minimized.

Copy link
@annevk

annevk Nov 5, 2018

Author Member

It would be good to add a note here illustrating that this is very different from how response Content-Type is parsed, but maybe that should wait until that's actually defined properly.

This comment has been minimized.

Copy link
@annevk

annevk Nov 9, 2018

Author Member

I'll do this as part of #529.

annevk added a commit to web-platform-tests/wpt that referenced this pull request Nov 9, 2018

@annevk annevk merged commit e06e261 into master Nov 9, 2018

2 checks passed

Participation annevk participates on behalf of Mozilla Corporation
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@annevk annevk deleted the annevk/request-content-type branch Nov 9, 2018

aarongable pushed a commit to chromium/chromium that referenced this pull request Nov 14, 2018

[CORS] Be strict on request's Content-Type
Following the corresponding spec change:
whatwg/fetch#829

Bug: 902681
Change-Id: If0da598ada489417c34926935acdd3cfff519aa7
Reviewed-on: https://chromium-review.googlesource.com/c/1329815
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607847}

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Nov 14, 2018

Bug 1504733 [wpt PR 13921] - Fetch: CORS and request's Content-Type h…
…eader, a=testonly

Automatic update from web-platform-testsFetch: CORS and request's Content-Type header

For whatwg/fetch#829.
--

wpt-commits: eed621bc2f995bced9481df2cead4c4632c72cdd
wpt-pr: 13921

staktrace pushed a commit to staktrace/gecko that referenced this pull request Nov 15, 2018

Bug 1504733 [wpt PR 13921] - Fetch: CORS and request's Content-Type h…
…eader, a=testonly

Automatic update from web-platform-testsFetch: CORS and request's Content-Type header

For whatwg/fetch#829.
--

wpt-commits: eed621bc2f995bced9481df2cead4c4632c72cdd
wpt-pr: 13921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.