Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scripts for deploying via Travis CI #117

Merged
merged 1 commit into from Aug 19, 2017

Conversation

@domenic
Copy link
Member

commented Aug 18, 2017

This adds a new subdirectory, ci-deploy, with scripts and other
resources for building, validating, and deploying the spec entirely on
Travis. Previously Travis was only running build and validation steps,
but then throwing away the results, letting custom deploy architecture
handle the actual deploy. This replaces the custom deploy architecture
with something in source control and web-host-agnostic.

This deploy is Docker-based, for two main reasons:

  • It is not easy to install FreePascal 3.x onto Travis CI's default
    Ubuntu configuration, which is fairly old (even with recent Trusty
    updates). It is simpler to create a Docker container with a recent OS
    and install FreePascal 3.x there.
  • Docker has a good mechanism for caching previous results and not doing
    unnecessary work until the cache is invalidated. This is important as
    it allows us to avoid reinstalling prerequisite packages and
    recompiling Wattsi on every build. Travis CI has some caching support,
    but it is not as full-featured as Docker's. The intermediate
    containers created for this caching are stored on Docker Hub; see
    https://hub.docker.com/r/whatwg/html-deploy.

The ci-deploy/README.md file contains more instructions on how this is
expected to be used, and will be used by whatwg/html's .travis.yml in
whatwg/html#2941.

@domenic domenic force-pushed the move-deploy branch 5 times, most recently from c7b3699 to 4243fb3 Aug 18, 2017

test.txt Outdated
@@ -0,0 +1 @@
93

This comment has been minimized.

Copy link
@annevk

annevk Aug 18, 2017

Member

This looks wrong?

This comment has been minimized.

Copy link
@domenic

domenic Aug 18, 2017

Author Member

Hah, good catch...

In general stuff is still in a bit of flux; will ping when a build succeeds.

@domenic domenic force-pushed the move-deploy branch 5 times, most recently from 6c66210 to 3a1ce5a Aug 18, 2017

@domenic

This comment has been minimized.

Copy link
Member Author

commented Aug 18, 2017

OK, this is ready for review. And it can be merged if people are happy with it; by itself merging this does nothing.

Add scripts for deploying via Travis CI
This adds a new subdirectory, ci-deploy, with scripts and other
resources for building, validating, and deploying the spec entirely on
Travis. Previously Travis was only running build and validation steps,
but then throwing away the results, letting custom deploy architecture
handle the actual deploy. This replaces the custom deploy architecture
with something in source control and web-host-agnostic.

This deploy is Docker-based, for two main reasons:

* It is not easy to install FreePascal 3.x onto Travis CI's default
  Ubuntu configuration, which is fairly old (even with recent Trusty
  updates). It is simpler to create a Docker container with a recent OS
  and install FreePascal 3.x there.
* Docker has a good mechanism for caching previous results and not doing
  unnecessary work until the cache is invalidated. This is important as
  it allows us to avoid reinstalling prerequisite packages and
  recompiling Wattsi on every build. Travis CI has some caching support,
  but it is not as full-featured as Docker's. The intermediate
  containers created for this caching are stored on Docker Hub; see
  https://hub.docker.com/r/whatwg/html-deploy.

The ci-deploy/README.md file contains more instructions on how this is
expected to be used, and will be used by whatwg/html's .travis.yml in
whatwg/html#2941.

Fixes #11. Fixes #99. Fixes #103.

@domenic domenic force-pushed the move-deploy branch from 3a1ce5a to 13f26a7 Aug 18, 2017

@sideshowbarker
Copy link
Member

left a comment

LGTM

@annevk annevk merged commit f4a2797 into master Aug 19, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@annevk annevk deleted the move-deploy branch Aug 19, 2017

annevk added a commit to whatwg/html that referenced this pull request Aug 19, 2017
alice added a commit to alice/html that referenced this pull request Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.