New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define rel=mask-icon #110

Closed
annevk opened this Issue Sep 5, 2015 · 9 comments

Comments

7 participants
@hober

This comment has been minimized.

Collaborator

hober commented Sep 14, 2015

I'll give this a go at some point this week.

@sideshowbarker

This comment has been minimized.

Member

sideshowbarker commented Dec 27, 2015

Lack of a spec for this is blocking ability to implement any support for it in the Nu HTML checker. We’ve so far gotten just one report about it in the issue tracker for the checker validator/validator#174 but I expect we’ll start to see more.

@laukstein

This comment has been minimized.

laukstein commented Mar 28, 2016

Any progress on how spec will look?

<link rel=mask-icon href=icon.svg color=#f38>
@zcorpan

This comment has been minimized.

Member

zcorpan commented Mar 31, 2016

This issue is about rel=mask-icon, which is separate from supporting SVG for rel=icon AIUI.

@dholbert

This comment has been minimized.

dholbert commented Apr 12, 2016

@laukstein : fyi, your "browsers status" comment here is actually orthogonal to the main thing this bug is about.

Your bug links there are for browsers supporting SVG images as favicons (rel="icon"). But this github-issue is about is about using an SVG mask (plus a color) instead of a favicon (rel="mask-icon"). Which is completely different, from a spec & an implementation perspective.

(I'd suggest either removing that github-comment (since it's not directly relevant to this issue), or editing it to clarify what those bug links are about (standard svg favicons, not mask-icon).)

@laukstein

This comment has been minimized.

laukstein commented Apr 13, 2016

@dholbert, thanks for noticing! The comment has been updated.

Stanton added a commit to jadu/pulsar that referenced this issue Jan 19, 2017

Remove safari pinned tab favicon to fix HTML validation issue
The color attribute on the <link> tag isn’t valid and throws an error in the W3C validator. This has been an ongoing discussion with the validator team and the WhatWG (For over a year).

See:
* validator/validator#174
* whatwg/html#110

Until this is resolved I see no alternative but to remove the safari pinned tab icon, which is made easier given the low usage statistics we have for Safari.

```Error: Attribute color not allowed on element link at this point.
From line 27, column 1; to line 27, column 108
st.json">↩<link rel="mask-icon" href="/jadu/bundles/pulsar/images/favicons/cms/safari-pinned-tab.svg" color="#15a6d1">↩<link
Attributes for element link:
Global attributes
href — Address of the hyperlink
crossorigin — How the element handles crossorigin requests
rel — Relationship of this document (or subsection/topic) to the destination resource
rev — Reverse link relationship of the destination resource to this document (or subsection/topic)
media — Applicable media
nonce — Cryptographic nonce used in Content Security Policy checks [CSP3]
hreflang — Language of the linked resource
type — Hint for the type of the referenced resource
sizes — Sizes of the icons (for rel="icon")
Also, the title attribute has special semantics on this element: Title of the link; alternative style sheet set name.```
@sideshowbarker

This comment has been minimized.

Member

sideshowbarker commented Mar 26, 2017

Should we close this now that #2230 has landed?

sideshowbarker added a commit to validator/validator that referenced this issue Mar 26, 2017

@domenic

This comment has been minimized.

Member

domenic commented Mar 27, 2017

Hmm, yeah, I suppose so. Let's also note that there was good discussion about whether to spec a processing model/reflected color IDL attribute in #2230 which came down at least for now on the side of not doing so, pending interest from a second implementer.

@domenic domenic closed this Mar 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment