Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should change/input events dispatched for checkbox and radiobutton have trustedness flag based on the triggering click? #1126

Closed
smaug---- opened this issue Apr 26, 2016 · 4 comments

Comments

@smaug----
Copy link
Collaborator

There is a wpt tests for input event at least which expect trusted flag to be inherited from click, but that is currently against the spec and will be changed for now at least.
But if we want to have trusted handling here to depend on the isTrusted of the click event, spec needs some change.

@cvrebert
Copy link
Member

Refs web-platform-tests/wpt#1418

zcorpan added a commit to web-platform-tests/wpt that referenced this issue May 2, 2016
This reverts
5d1a5c1
3775815

Also test that isTrusted is false for the click event.

Ref.
whatwg/html#1126
#1418 (comment)
@zcorpan
Copy link
Member

zcorpan commented May 2, 2016

They are trusted in Gecko and Chromium at least. I've submitted a PR to fix the tests. Do you think the spec should change instead?

@smaug----
Copy link
Collaborator Author

I don't know. I just filed the bug when reviewing patches where someone was doing changes to the relevant code in Gecko and she noticed that bug in wpt tests. So wpt tests in Gecko are already fixed. That should get merged to github at some point.

Couldn't figure out at that time why web-platform-tests/wpt#1418 was ever filed or "fixed"

zcorpan added a commit to web-platform-tests/wpt that referenced this issue May 9, 2016
This reverts
5d1a5c1

Also test that isTrusted is false for the click event.

Ref.
whatwg/html#1126
#1418 (comment)
#2991
arronei pushed a commit to arronei/web-platform-tests that referenced this issue Jun 14, 2016
ivanzr pushed a commit to ivanzr/web-platform-tests that referenced this issue Jun 29, 2016
@annevk
Copy link
Member

annevk commented Oct 25, 2016

Keeping these trusted seems fine per recent discussion on what trusted means. Seems test changes landed, so closing this.

@annevk annevk closed this as completed Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants