New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should change/input events dispatched for checkbox and radiobutton have trustedness flag based on the triggering click? #1126
Comments
This reverts 5d1a5c1 3775815 Also test that isTrusted is false for the click event. Ref. whatwg/html#1126 #1418 (comment)
They are trusted in Gecko and Chromium at least. I've submitted a PR to fix the tests. Do you think the spec should change instead? |
I don't know. I just filed the bug when reviewing patches where someone was doing changes to the relevant code in Gecko and she noticed that bug in wpt tests. So wpt tests in Gecko are already fixed. That should get merged to github at some point. Couldn't figure out at that time why web-platform-tests/wpt#1418 was ever filed or "fixed" |
This reverts 5d1a5c1 Also test that isTrusted is false for the click event. Ref. whatwg/html#1126 #1418 (comment) #2991
This reverts 5d1a5c1 Also test that isTrusted is false for the click event. Ref. whatwg/html#1126 web-platform-tests#1418 (comment) web-platform-tests#2991
This reverts 5d1a5c1 Also test that isTrusted is false for the click event. Ref. whatwg/html#1126 web-platform-tests#1418 (comment) web-platform-tests#2991
Keeping these trusted seems fine per recent discussion on what trusted means. Seems test changes landed, so closing this. |
There is a wpt tests for input event at least which expect trusted flag to be inherited from click, but that is currently against the spec and will be changed for now at least.
But if we want to have trusted handling here to depend on the isTrusted of the click event, spec needs some change.
The text was updated successfully, but these errors were encountered: