-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<embed> does not handle network errors #1461
Comments
|
Closed by 63a0e64 but GitHub isn't picking that up... there seems to be some general degraded GitHub status. |
Fixes #4024. Fixes #1461. Tests: web-platform-tests/wpt#24518
@domenic, should we be able to identify trough JavaScript if iframe failed to load (is blocked by network or CSP)? Currently with what I can came up is in onload event
but it will fail on Firefox due to issue https://bugzilla.mozilla.org/show_bug.cgi?id=1552504 Is there any spec approach for it? |
@mfreed7 was it security concern to fire onload and not onerror when iframe failed to load by CSP or blocked network? Otherwise it should be considered as a bug in spec. cc @domenic @paulirish |
It is intentional to align with 2/3 browsers here. Embed is a legacy element and we are working to simplify it as much as possible. |
@domenic, I am referring to <iframe> element. I think Chrome Issue #365457, Issue #899559 and Issue #938279, and likely other browsers are missing this part
Chrome doesn't fire error event and instead fires load event when iframe load failed by CSP or other reason. |
Yes, that's per spec, and also unrelated to this issue, so this is not a good place to discuss it. |
@domenic, can you please collaborate in https://bugs.chromium.org/p/chromium/issues/detail?id=899559#c9 and make clear the iframe error spec? I think there has been some misunderstanding. |
The current set of steps seem to assume there's always a response.
The text was updated successfully, but these errors were encountered: