Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec hole in <tbody> 'deleteRow' and <tr> 'deleteCell' #248

Closed
frewsxcv opened this issue Oct 12, 2015 · 4 comments
Closed

Spec hole in <tbody> 'deleteRow' and <tr> 'deleteCell' #248

frewsxcv opened this issue Oct 12, 2015 · 4 comments
Labels
good first issue Ideal for someone new to a WHATWG standard or software project

Comments

@frewsxcv
Copy link
Member

"remove the last element in the rows collection" makes no sense if the rows collection is empty

https://html.spec.whatwg.org/multipage/#dom-tr-deletecell

https://html.spec.whatwg.org/multipage/#dom-tbody-deleterow
@frewsxcv
Copy link
Member Author

Relevant conversation: servo/servo#7977 (comment)

@frewsxcv frewsxcv mentioned this issue Oct 12, 2015
Merged
@Ms2ger
Copy link
Member

Ms2ger commented Oct 12, 2015

tbody and friends, not td. Note that table handles the case.

@frewsxcv frewsxcv changed the title Spec hole in <td> 'deleteRow' and <tr> 'deleteCell' Spec hole in <tbody> 'deleteRow' and <tr> 'deleteCell' Oct 12, 2015
@frewsxcv
Copy link
Member Author

Update for future selves: update this test case

@annevk annevk added the good first issue Ideal for someone new to a WHATWG standard or software project label Oct 13, 2015
@frewsxcv
Copy link
Member Author

This issue also applies to <table> deleteCell

https://html.spec.whatwg.org/multipage/tables.html#dom-table-deleterow

domenic added a commit that referenced this issue Apr 22, 2016
@domenic
Fix #248: specify an edge-case in tbody.deleteRow and td.deleteCell
2250069
domenic added a commit that referenced this issue Apr 28, 2016
@domenic
Fix #248: specify an edge-case in tbody.deleteRow and td.deleteCell
7a4088b
@annevk annevk closed this as completed in b9105c7 Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Ideal for someone new to a WHATWG standard or software project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Ms2ger @frewsxcv @annevk