New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a [[IsHTMLDDA]] internal slot to document.all #3015

Closed
TimothyGu opened this Issue Sep 7, 2017 · 2 comments

Comments

3 participants
@TimothyGu
Member

TimothyGu commented Sep 7, 2017

Now that tc39/ecma262#673 has been merged, we should add the newly defined [[IsHTMLDDA]] internal slot to either document.all specifically or HTMLAllCollection instances generically -- they are equivalent. I personally prefer adding it to HTMLAllCollection, where other obsoleted features like legacy caller behavior are specified.

Refs: https://tc39.github.io/ecma262/#sec-IsHTMLDDA-internal-slot

@TimothyGu TimothyGu changed the title from Add a [[IsHTMLDDA]] to Add a [[IsHTMLDDA]] internal slot to document.all Sep 7, 2017

@annevk

This comment has been minimized.

Show comment
Hide comment
@annevk

annevk Sep 7, 2017

Member

Maybe this can be done as part of #2932?

Member

annevk commented Sep 7, 2017

Maybe this can be done as part of #2932?

@TimothyGu

This comment has been minimized.

Show comment
Hide comment
@TimothyGu

TimothyGu Sep 7, 2017

Member

@annevk It could be, but I'd rather not. They are logically distinct changes.

Member

TimothyGu commented Sep 7, 2017

@annevk It could be, but I'd rather not. They are logically distinct changes.

@TimothyGu TimothyGu referenced this issue Sep 8, 2017

Closed

buffer: improve Buffer.from performance #15178

2 of 2 tasks complete

TimothyGu added a commit to TimothyGu/html that referenced this issue Oct 2, 2017

@annevk annevk closed this in #3087 Oct 2, 2017

annevk added a commit that referenced this issue Oct 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment