New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window open steps use tokenizedFeatures before setting it #3107

Closed
bzbarsky opened this Issue Oct 9, 2017 · 2 comments

Comments

2 participants
@bzbarsky
Collaborator

bzbarsky commented Oct 9, 2017

https://html.spec.whatwg.org/multipage/window-object.html#window-open-steps step 4 uses tokenizedFeatures, but that's not defined until step 7. Presumably someone moved the noopener bit without moving its dependency...

@annevk

This comment has been minimized.

Show comment
Hide comment
@annevk

annevk Oct 9, 2017

Member

Hmm yeah, seems @mystor regressed this in a68a1f7 and @domenic and I didn't catch it during review.

Member

annevk commented Oct 9, 2017

Hmm yeah, seems @mystor regressed this in a68a1f7 and @domenic and I didn't catch it during review.

@annevk

This comment has been minimized.

Show comment
Hide comment
@annevk

annevk Oct 9, 2017

Member

Pushed a fix.

Member

annevk commented Oct 9, 2017

Pushed a fix.

@domenic domenic closed this in #3108 Oct 9, 2017

domenic added a commit that referenced this issue Oct 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment