Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dataset from HTMLElement to a mixin shared with SVGElement #3471

Closed
annevk opened this Issue Feb 16, 2018 · 4 comments

Comments

2 participants
@annevk
Copy link
Member

annevk commented Feb 16, 2018

See whatwg/dom#280 for the original issue and w3c/svgwg#60 for the corresponding SVG issue. It seems this is already what implementations are aligning on.

(@dstorey notes tabIndex, focus(), etc. might also need to be moved, but that's probably best considered (and tested) separately?)

@dstorey

This comment has been minimized.

Copy link
Member

dstorey commented Mar 7, 2018

@annevk do you want a separate issue for moving tabIndex, focus, blur to a mixin?
We discussed it on the SVG call and they're all defined as behaving the same as HTML: https://svgwg.org/svg2-draft/types.html#__svg__SVGElement__tabIndex
I added them in Edge and they're use the same behaviour.

@annevk

This comment has been minimized.

Copy link
Member Author

annevk commented Mar 7, 2018

I guess we can use this issue for all of them. Did you add web-platform-tests?

@dstorey

This comment has been minimized.

Copy link
Member

dstorey commented Mar 7, 2018

Not yet but I'm taking on adding SVG tests for https://svgwg.org/svg2-draft/types.html so I'll be submitting them as part of that

annevk added a commit that referenced this issue Mar 7, 2018

Add HTMLOrSVGElement interface mixin
This exposes dataset, tabIndex, focus(), and blur() on SVG elements.

It also does away with NoncedElement.

Tests: ...

Fixes #3471.
@annevk

This comment has been minimized.

Copy link
Member Author

annevk commented Mar 7, 2018

@dstorey change for the HTML Standard is in #3543.

@annevk annevk closed this in #3543 Mar 23, 2018

annevk added a commit that referenced this issue Mar 23, 2018

Add HTMLOrSVGElement interface mixin
This exposes dataset, tabIndex, focus(), and blur() on SVG elements.

It also does away with NoncedElement.

Tests: web-platform-tests/wpt#10110 and web-platform-tests/wpt#10149 (dataset tests for SVG already exist).

Fixes #3471 and fixes w3c/svgwg#60.

yutakahirano added a commit to yutakahirano/html that referenced this issue Apr 26, 2018

Add HTMLOrSVGElement interface mixin
This exposes dataset, tabIndex, focus(), and blur() on SVG elements.

It also does away with NoncedElement.

Tests: web-platform-tests/wpt#10110 and web-platform-tests/wpt#10149 (dataset tests for SVG already exist).

Fixes whatwg#3471 and fixes w3c/svgwg#60.

alice added a commit to alice/html that referenced this issue Jan 8, 2019

Add HTMLOrSVGElement interface mixin
This exposes dataset, tabIndex, focus(), and blur() on SVG elements.

It also does away with NoncedElement.

Tests: web-platform-tests/wpt#10110 and web-platform-tests/wpt#10149 (dataset tests for SVG already exist).

Fixes whatwg#3471 and fixes w3c/svgwg#60.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.