Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "type" from "form data set" entry #3648

Closed
tkent-google opened this issue Apr 27, 2018 · 2 comments · Fixed by whatwg/url#384, whatwg/xhr#206 or #3658

Comments

@tkent-google
Copy link
Collaborator

commented Apr 27, 2018

https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#constructing-the-form-data-set

  1. Let the form data set be a list of name-value-type tuples, initially empty.

The type is used only to check "it's file or not" in each of form encodings.
I think we can simplify specifications by changing the checks to something like "if the value is a file ..."

This affects URL specification and XHR specification as well as HTML specification.
https://url.spec.whatwg.org/#concept-urlencoded-serializer
https://xhr.spec.whatwg.org/#concept-formdata-entry

This change should not affect UA behavior.

@annevk

This comment has been minimized.

Copy link
Member

commented Apr 27, 2018

Yeah, I think that would be great. I wonder if we can go even further and always talk about File objects here.

tkent-google added a commit to tkent-google/xhr that referenced this issue May 1, 2018
tkent-google added a commit to tkent-google/url that referenced this issue May 1, 2018
annevk added a commit to whatwg/xhr that referenced this issue May 8, 2018
This fixes part of whatwg/html#3648.
annevk added a commit to whatwg/url that referenced this issue May 8, 2018
This fixes part of whatwg/html#3648.
@annevk

This comment has been minimized.

Copy link
Member

commented May 8, 2018

I forgot to link a1e8b1a to this, but this is all done now. Thanks @tkent-google for the cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.