New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fieldset should force used value of 'display' for some values #3915

Closed
zcorpan opened this Issue Aug 14, 2018 · 1 comment

Comments

1 participant
@zcorpan
Member

zcorpan commented Aug 14, 2018

Part of #3660

Fieldset needs to override used 'display' for some values.

inline, inline-block, inline-table, ruby, ruby-* -> inline-block
block, table, table-*, list-item, run-in, flow, flow-root -> block

These should work: none, flex, inline-flex, grid, inline-grid, contents, layout() ?

@zcorpan

This comment has been minimized.

Show comment
Hide comment
@zcorpan

zcorpan Aug 14, 2018

Member

Tests for grid, inline-grid web-platform-tests/wpt#12477

Tests for flex, inline-flex web-platform-tests/wpt#12489

Tests for blocks and inlines web-platform-tests/wpt#12494

Tests for contents web-platform-tests/wpt#8699

Member

zcorpan commented Aug 14, 2018

Tests for grid, inline-grid web-platform-tests/wpt#12477

Tests for flex, inline-flex web-platform-tests/wpt#12489

Tests for blocks and inlines web-platform-tests/wpt#12494

Tests for contents web-platform-tests/wpt#8699

zcorpan added a commit to web-platform-tests/wpt that referenced this issue Aug 15, 2018

zcorpan added a commit to web-platform-tests/wpt that referenced this issue Aug 20, 2018

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Aug 23, 2018

Bug 1483502 [wpt PR 12494] - HTML: fieldset used value for CSS 'displ…
…ay', a=testonly

Automatic update from web-platform-testsHTML: fieldset used value for CSS 'display'

See whatwg/html#3915.
--

wpt-commits: 1fbb6c1db6321c617158e2291168e75e1af1d209
wpt-pr: 12494

jankeromnes pushed a commit to jankeromnes/gecko that referenced this issue Aug 23, 2018

Bug 1483502 [wpt PR 12494] - HTML: fieldset used value for CSS 'displ…
…ay', a=testonly

Automatic update from web-platform-testsHTML: fieldset used value for CSS 'display'

See whatwg/html#3915.
--

wpt-commits: 1fbb6c1db6321c617158e2291168e75e1af1d209
wpt-pr: 12494

zcorpan added a commit to web-platform-tests/wpt that referenced this issue Aug 27, 2018

zcorpan added a commit that referenced this issue Sep 19, 2018

Revamp how fieldset and legend rendering is defined
Properly define the rendering of the fieldset and legend elements.

The layout model used is most similar to Gecko, which uses an anonymous box to hold the fieldset's contents.

Fixes #3955, fixes #3930, fixes #3929, fixes #3928, fixes #3927, fixes #3915, fixes #3913, fixes #3660, fixes #3331, fixes #2756, fixes #4013.

Tests:
https://github.com/web-platform-tests/wpt/tree/master/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements
https://github.com/web-platform-tests/wpt/tree/master/html/semantics/forms/the-fieldset-element
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment