New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fieldset's "rendered legend" should force used value of display to block #3927

Closed
zcorpan opened this Issue Aug 15, 2018 · 1 comment

Comments

2 participants
@zcorpan
Member

zcorpan commented Aug 15, 2018

Except 'none' and 'contents' should work (and make it not be the "rendered legend").

WebKit/Chromium make the computed value be "block" (maybe have display: block !important as UA style?), while Firefox seems to override used value (with some bugs).

zcorpan added a commit to web-platform-tests/wpt that referenced this issue Aug 15, 2018

zcorpan added a commit to web-platform-tests/wpt that referenced this issue Aug 23, 2018

zcorpan added a commit to web-platform-tests/wpt that referenced this issue Aug 27, 2018

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Aug 29, 2018

Bug 1483776 [wpt PR 12513] - HTML: fieldset's "rendered legend" used …
…value of display is block, a=testonly

Automatic update from web-platform-testsHTML: fieldset's "rendered legend" used value of display is block

See whatwg/html#3927
--

wpt-commits: 0e10a5e47320a06c6f049fabcdfc6bd36922dc83
wpt-pr: 12513

jankeromnes pushed a commit to jankeromnes/gecko that referenced this issue Aug 29, 2018

Bug 1483776 [wpt PR 12513] - HTML: fieldset's "rendered legend" used …
…value of display is block, a=testonly

Automatic update from web-platform-testsHTML: fieldset's "rendered legend" used value of display is block

See whatwg/html#3927
--

wpt-commits: 0e10a5e47320a06c6f049fabcdfc6bd36922dc83
wpt-pr: 12513
@zcorpan

This comment has been minimized.

Show comment
Hide comment
@zcorpan
Member

zcorpan commented Aug 31, 2018

See #3969

zcorpan added a commit that referenced this issue Sep 19, 2018

Revamp how fieldset and legend rendering is defined
Properly define the rendering of the fieldset and legend elements.

The layout model used is most similar to Gecko, which uses an anonymous box to hold the fieldset's contents.

Fixes #3955, fixes #3930, fixes #3929, fixes #3928, fixes #3927, fixes #3915, fixes #3913, fixes #3660, fixes #3331, fixes #2756, fixes #4013.

Tests:
https://github.com/web-platform-tests/wpt/tree/master/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements
https://github.com/web-platform-tests/wpt/tree/master/html/semantics/forms/the-fieldset-element
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment