Skip to content

Conversation

@domenic
Copy link
Member

@domenic domenic commented Aug 9, 2016

Fixes #1636.

@domenic domenic added topic: parser topic: custom elements Relates to custom elements (as defined in DOM and HTML) labels Aug 9, 2016
@domenic
Copy link
Member Author

domenic commented Aug 9, 2016

/cc @dominiccooney @kojiishi as this may be a good thing to add test coverage for (i.e. <x-foo attr="1" attr="2"> should only fire one attributeChangedCallback, with value 1). (Does Daava have a GitHub handle?)

@annevk
Copy link
Member

annevk commented Aug 9, 2016

I wonder if I'm missing something around duplicate attributes. Not even @Hixie's old algorithm in 3a88aa5 handled it.

@annevk
Copy link
Member

annevk commented Aug 9, 2016

I did miss something. @zcorpan pointed out that a sentence following https://html.spec.whatwg.org/#attribute-name-state handles it.

@annevk
Copy link
Member

annevk commented Aug 9, 2016

My recommendation is that we close this PR and invalidate the issue. We could perhaps inline the statement following the Attribute name state as @zcorpan suggested.

@domenic
Copy link
Member Author

domenic commented Aug 10, 2016

Works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: custom elements Relates to custom elements (as defined in DOM and HTML) topic: parser

Development

Successfully merging this pull request may close these issues.

3 participants