Don't serialize an extra LF in <pre>, <textarea>, <listing> #1815

Merged
merged 2 commits into from Sep 24, 2016

Projects

None yet

2 participants

@zcorpan
Member
zcorpan commented Sep 23, 2016

This was implemented in Presto in ~2012, and recently implemented
in Gecko, but it broke CKEditor (http://dev.ckeditor.com/ticket/14814#ticket)
so it is being backed out again in Gecko.

Fixes #944.

@zcorpan zcorpan Don't serialize an extra LF in <pre>, <textarea>, <listing>
This was implemented in Presto in ~2012, and recently implemented
in Gecko, but it broke CKEditor (http://dev.ckeditor.com/ticket/14814#ticket)
so it is being backed out again in Gecko.

Fixes #944.
7a568a4
@zcorpan zcorpan added a commit to w3c/web-platform-tests that referenced this pull request Sep 23, 2016
@zcorpan zcorpan Change expected serialization of <pre>\n\nx</pre> c5ce00b
@domenic domenic Suggested changes
b6dba41
@domenic
Member
domenic commented Sep 23, 2016

Normative changes LGTM; made some tweaks to the example. Let me know what you think.

@zcorpan
Member
zcorpan commented Sep 24, 2016

👌

@domenic domenic merged commit 2aa0000 into master Sep 24, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@domenic domenic deleted the fragment-serialization-newline branch Sep 24, 2016
@zcorpan zcorpan added a commit to w3c/web-platform-tests that referenced this pull request Sep 24, 2016
@zcorpan zcorpan Change html/syntax/serializing-html-fragments/serializing.html for <p…
…re>\n

See
whatwg/html#1815
#3814

Also change .replace() to avoid non-standard "g" as third argument.
1f2f694
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment