New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't serialize an extra LF in <pre>, <textarea>, <listing> #1815

Merged
merged 2 commits into from Sep 24, 2016

Conversation

2 participants
@zcorpan
Member

zcorpan commented Sep 23, 2016

This was implemented in Presto in ~2012, and recently implemented
in Gecko, but it broke CKEditor (http://dev.ckeditor.com/ticket/14814#ticket)
so it is being backed out again in Gecko.

Fixes #944.

Don't serialize an extra LF in <pre>, <textarea>, <listing>
This was implemented in Presto in ~2012, and recently implemented
in Gecko, but it broke CKEditor (http://dev.ckeditor.com/ticket/14814#ticket)
so it is being backed out again in Gecko.

Fixes #944.
@domenic

This comment has been minimized.

Show comment
Hide comment
@domenic

domenic Sep 23, 2016

Member

Normative changes LGTM; made some tweaks to the example. Let me know what you think.

Member

domenic commented Sep 23, 2016

Normative changes LGTM; made some tweaks to the example. Let me know what you think.

@zcorpan

This comment has been minimized.

Show comment
Hide comment
@zcorpan

zcorpan Sep 24, 2016

Member

👌

Member

zcorpan commented Sep 24, 2016

👌

@domenic domenic merged commit 2aa0000 into master Sep 24, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@domenic domenic deleted the fragment-serialization-newline branch Sep 24, 2016

zcorpan added a commit to web-platform-tests/wpt that referenced this pull request Sep 24, 2016

Change html/syntax/serializing-html-fragments/serializing.html for <p…
…re>\n

See
whatwg/html#1815
#3814

Also change .replace() to avoid non-standard "g" as third argument.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment