Remove "compatibility caseless" matching #1941

Merged
merged 1 commit into from Oct 24, 2016

Projects

None yet

3 participants

@domenic
Member
domenic commented Oct 20, 2016

This fixes #1666. As discussed there, browsers are not interoperable
about what type of Unicode case-insensitivity they implement here, with
WebKit even using case-sensitive matching for the radio button case (but
not for the image map case). Data from Blink's use counters reveals
however that the Unicode case-insensitivity is never triggered, and even
ASCII case-insensitivity is triggered extraordinarily rarely.
Additionally, the semantics of these attributes is more like an
identifier than anything else, and so case-insensitive comparison never
really made sense in the first place (it was only done for legacy
Internet Explorer compatibility). As such, we move to converge on
case-sensitive matching in all cases.

Tests incoming, will file browser bugs after merge.

@domenic domenic Remove "compatibility caseless" matching
This fixes #1666. As discussed there, browsers are not interoperable
about what type of Unicode case-insensitivity they implement here, with
WebKit even using case-sensitive matching for the radio button case (but
not for the image map case). Data from Blink's use counters reveals
however that the Unicode case-insensitivity is never triggered, and even
ASCII case-insensitivity is triggered extraordinarily rarely.
Additionally, the semantics of these attributes is more like an
identifier than anything else, and so case-insensitive comparison never
really made sense in the first place (it was only done for legacy
Internet Explorer compatibility). As such, we move to converge on
case-sensitive matching in all cases.
522d77d
@domenic domenic added a commit to w3c/web-platform-tests that referenced this pull request Oct 20, 2016
@domenic domenic Test that radio button group name matching is case-sensitive
This follows the spec change proposed at whatwg/html#1941.
e13a1a1
@domenic domenic added a commit to w3c/web-platform-tests that referenced this pull request Oct 20, 2016
@domenic domenic Test that radio button group name matching is case-sensitive
This follows the spec change proposed at whatwg/html#1941.
e717f5a
@domenic
Member
domenic commented Oct 20, 2016

Tests at w3c/web-platform-tests#4044 for radio button groups. I can't figure out how to test image maps. It might be possible with something really complicated (synethetic click events at some section of the page that is covered by an image map??) but given that there are no such existing tests for me to model on, I'm going to ask that we skip requiring tests for that.

@domenic domenic added a commit to w3c/web-platform-tests that referenced this pull request Oct 20, 2016
@domenic domenic Test that radio button group name matching is case-sensitive
This follows the spec change proposed at whatwg/html#1941.
8458e23
@annevk
Member
annevk commented Oct 21, 2016

I don't think you can test it without some kind of framework that can actually send UI events. However, you could create a manual test for it which would be nice for implementers and reviewers.

Really happy we can remove this wart by the way.

@zcorpan
Member
zcorpan commented Oct 21, 2016

You can use elementFromPoint(), see /html/semantics/embedded-content/the-area-element/area-coords.html for an example. (If the map is associated, you get an area element; if not, you get the img.)

@domenic
Member
domenic commented Oct 21, 2016

Thanks for the tip. Tests updated. Anyone approve the PR itself?

@annevk
Member
annevk commented Oct 22, 2016

Oops, this PR LGTM.

@domenic domenic merged commit 6acdb21 into master Oct 24, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@domenic domenic deleted the case-sensitivity branch Oct 24, 2016
@domenic domenic added a commit to w3c/web-platform-tests that referenced this pull request Oct 24, 2016
@domenic domenic Test the removal of Unicode case-insensitive radio/usemaps
This follows the spec change proposed at whatwg/html#1941.
2017bf8
@zcorpan zcorpan added a commit to w3c/web-platform-tests that referenced this pull request Dec 21, 2016
@tkent-google @zcorpan tkent-google + zcorpan [html] Radio button group name should be case-sensitive (#4374)
The testcase didn't match to the current specification.

See whatwg/html#1941
c247c88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment